Make TestEventTrigger delegate testable and extensible #31724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make TestEventTriggerDelegate base class manage multiple sub-handlers.
- Add unit tests for TestEventTriggerDelegate
- Introduce an interface for generic TestEventTrigger handlers
- Add Clear() method to Intrusive list to remove everything.
- Document the fact that `emberAfHandleEventTrigger` should NOT be used
- Update all examples as needed.
- Renumber OTA and SmokeCO testevent trigger prefix to match new Matter 1.3
standard (first 16 bits == cluster ID being tested).
- Clean-up dead code
- Register OTA test event handler as intended.
- Add TODOs for platforms to clean-up TestEventTriggerDelegate registration.
- Updated BOOLCFG tests to use `--hex-arg` for PIXIT since `--int-arg` is too
confusing with complex keys.
Issue project-chip#31723
Testing done:
- EEVSE Python tests using event triggers pass
- SMOKECO YAML tests using event triggers pass
- BOOLCFG Python tests using event triggers pass
- TC_TestEventTrigger passes
- New unit tests pass
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #31724: Size comparison from 09324e7 to 7945e9a Increases above 0.2%:
Increases (4 builds for cc32xx, qpg)
Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
|
PR #31724: Size comparison from 09324e7 to 1241100 Increases above 0.2%:
Increases (35 builds for cc32xx, cyw30739, k32w, linux, nrfconnect, psoc6, qpg)
Decreases (2 builds for linux)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #31724: Size comparison from 09324e7 to 47a88a0 Increases above 0.2%:
Increases (35 builds for cc32xx, cyw30739, k32w, linux, nrfconnect, psoc6, qpg)
Decreases (11 builds for cc13x4_26x4, efr32, esp32, k32w, linux)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
|
PR #31724: Size comparison from 09324e7 to 61e7a5e Increases above 0.2%:
Increases (36 builds for cc32xx, cyw30739, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (24 builds for cc13x4_26x4, efr32, esp32, k32w, linux, telink)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
approved these changes
Jan 28, 2024
ReneJosefsen
approved these changes
Jan 29, 2024
mkardous-silabs
approved these changes
Jan 29, 2024
cecille
reviewed
Jan 29, 2024
tcarmelveilleux
added a commit
to tcarmelveilleux/connectedhomeip
that referenced
this pull request
Jan 29, 2024
- Post-submit fix related to project-chip#31724
andy31415
pushed a commit
that referenced
this pull request
Jan 29, 2024
- Post-submit fix related to #31724
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…project-chip#31724) * Make TestEventTrigger delegate testable and extensible - Make TestEventTriggerDelegate base class manage multiple sub-handlers. - Add unit tests for TestEventTriggerDelegate - Introduce an interface for generic TestEventTrigger handlers - Add Clear() method to Intrusive list to remove everything. - Document the fact that `emberAfHandleEventTrigger` should NOT be used - Update all examples as needed. - Renumber OTA and SmokeCO testevent trigger prefix to match new Matter 1.3 standard (first 16 bits == cluster ID being tested). - Clean-up dead code - Register OTA test event handler as intended. - Add TODOs for platforms to clean-up TestEventTriggerDelegate registration. - Updated BOOLCFG tests to use `--hex-arg` for PIXIT since `--int-arg` is too confusing with complex keys. Issue project-chip#31723 Testing done: - EEVSE Python tests using event triggers pass - SMOKECO YAML tests using event triggers pass - BOOLCFG Python tests using event triggers pass - TC_TestEventTrigger passes - New unit tests pass * Fix merge issue * Restyled by clang-format * Fix uninitialized variable access * Fix Ameba/Silabs build * Fix CopyString bound * More fixes of Ameba/Silabs build --------- Co-authored-by: Restyled.io <commits@restyled.io> Cherry-picked from: 4cd1825
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…tensible (project-chip#31724)" This reverts commit 70be330.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emberAfHandleEventTriggershould NOT be used--hex-argfor PIXIT since--int-argis too confusing with complex keys.Issue #31723
Testing done: