Restyle Remove explicit malloc()-family calls from first-party code. #3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![restyled-io[bot]](https://avatars.githubusercontent.com/in/5851?s=60&v=4){kind=small}
#### Problem Embedded device-side code should only use heap through CHIPMem.h. In particular it should not call malloc()-family functions. #### Summary of Changes - Replace direct calls to malloc()/calloc()/realloc()/free(). - Ensure that malloc()-family calls in non-device code are suitably guarded by #ifs. - Add a C wrapper for Platform::Memory… functions, for src/lwip/standalone/sys_arch.c and platform C. - Add a str[n]dup() equivalent, as calls are paired with free(). fixes #2807 Remove explicit use of malloc() from first-party embedded-device code fixes #3092 CHIPMem.h called from C
restyled-io
bot
force-pushed
the
restyled/pull-3143
branch
from
93c9862 to
c85ae3e
Compare
restyled-io
bot
force-pushed
the
restyled/pull-3143
branch
from
c85ae3e to
a317b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #3143 with additional commits that automatically address
incorrect style, created by Restyled.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.