Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unneeded dependencies from generic-callbacks.h #32051

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Remove some unneeded dependencies from generic-callbacks.h #32051

merged 1 commit into from
Feb 14, 2024

Conversation

andy31415
Copy link
Contributor

Without this, we have seemingly looping dependencies in via stuff that is related to CommandHandling and app/util/af.h.

Before:

image

After:

image

@github-actions github-actions bot added the app label Feb 9, 2024
@andy31415
Copy link
Contributor Author

andy31415 commented Feb 9, 2024 •
edited
Loading

I could also pull in CommandResponseHelper out, however generally CommandHandler bits and CommandResponseHelper seemed related so I assumed they would eventually go in the same source_set/library

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

PR #32051: Size comparison from ea4fc7c to bff21b2

Decreases (1 build for efr32)
platform target config section ea4fc7c bff21b2 change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1123108 1123100 -8 -0.0
.text 932008 932000 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section ea4fc7c bff21b2 change % change
bl602 lighting-app bl602 (read/write) 1430938 1430938 0 0.0
.bss 85320 85320 0 0.0
.data 9496 9496 0 0.0
.rodata 157436 157436 0 0.0
.text 1098044 1098044 0 0.0
bl602+mfd (read/write) 1445346 1445346 0 0.0
.bss 85480 85480 0 0.0
.data 9472 9472 0 0.0
.rodata 156396 156396 0 0.0
.text 1113346 1113346 0 0.0
bl602+rpc (read/write) 1478322 1478322 0 0.0
.bss 93352 93352 0 0.0
.data 9872 9872 0 0.0
.rodata 165004 165004 0 0.0
.text 1129430 1129430 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1195507 1195507 0 0.0
.bss 11121 11121 0 0.0
.data 3680 3680 0 0.0
.rodata 106820 106820 0 0.0
.text 967050 967050 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1206559 1206559 0 0.0
.bss 11297 11297 0 0.0
.data 3656 3656 0 0.0
.rodata 105760 105760 0 0.0
.text 979060 979060 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1287231 1287231 0 0.0
.bss 19589 19589 0 0.0
.data 4224 4224 0 0.0
.rodata 122192 122192 0 0.0
.text 1041994 1041994 0 0.0
bl706-eth (read/write) 1014145 1014145 0 0.0
.bss 23680 23680 0 0.0
.data 3248 3248 0 0.0
.rodata 100140 100140 0 0.0
.text 759124 759124 0 0.0
bl706-wifi (read/write) 1247334 1247334 0 0.0
.bss 10565 10565 0 0.0
.data 3688 3688 0 0.0
.rodata 121120 121120 0 0.0
.text 989556 989556 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1165084 1165084 0 0.0
.bss 16316 16316 0 0.0
.data 5040 5040 0 0.0
.rodata 100824 100824 0 0.0
.text 960152 960152 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1176492 1176492 0 0.0
.bss 16492 16492 0 0.0
.data 5024 5024 0 0.0
.rodata 99764 99764 0 0.0
.text 972474 972474 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 781396 781396 0 0.0
(read/write) 168896 168896 0 0.0
.bss 90884 90884 0 0.0
.data 3568 3568 0 0.0
.rodata 90372 90372 0 0.0
.text 690760 690760 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 800284 800284 0 0.0
(read/write) 179160 179160 0 0.0
.bss 101164 101164 0 0.0
.data 3560 3560 0 0.0
.rodata 84772 84772 0 0.0
.text 715248 715248 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788868 788868 0 0.0
(read/write) 173608 173608 0 0.0
.bss 95612 95612 0 0.0
.data 3560 3560 0 0.0
.rodata 111516 111516 0 0.0
.text 677088 677088 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 739180 739180 0 0.0
(read/write) 167856 167856 0 0.0
.bss 89624 89624 0 0.0
.data 3552 3552 0 0.0
.rodata 86092 86092 0 0.0
.text 652824 652824 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724804 724804 0 0.0
(read/write) 168072 168072 0 0.0
.bss 89840 89840 0 0.0
.data 3552 3552 0 0.0
.rodata 81932 81932 0 0.0
.text 642608 642608 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 581338 581338 0 0.0
(read/write) 207976 207976 0 0.0
.bss 201212 201212 0 0.0
.data 1640 1640 0 0.0
.rodata 86530 86530 0 0.0
.text 492684 492684 0 0.0
lock CC3235SF_LAUNCHXL (read only) 628794 628794 0 0.0
(read/write) 208368 208368 0 0.0
.bss 201744 201744 0 0.0
.data 1504 1504 0 0.0
.rodata 107138 107138 0 0.0
.text 519532 519532 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 564843 564843 0 0.0
.app_xip_area 454701 454701 0 0.0
.bss 64976 64976 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 549955 549955 0 0.0
.app_xip_area 435013 435013 0 0.0
.bss 69768 69768 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566491 566491 0 0.0
.app_xip_area 457845 457845 0 0.0
.bss 63512 63512 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 563299 563299 0 0.0
.app_xip_area 451341 451341 0 0.0
.bss 66752 66752 0 0.0
.data 784 784 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 928728 928728 0 0.0
.bss 197904 197904 0 0.0
.data 1388 1388 0 0.0
.text 729416 729416 0 0.0
BRD4187C (read/write) 1105488 1105488 0 0.0
.bss 195100 195100 0 0.0
.data 3404 3404 0 0.0
.text 906964 906964 0 0.0
lock-app BRD4161A+wf200 (read/write) 1123108 1123100 -8 -0.0
.bss 188288 188288 0 0.0
.data 2792 2792 0 0.0
.text 932008 932000 -8 -0.0
window-app BRD4187C (read/write) 1159688 1159688 0 0.0
.bss 168884 168884 0 0.0
.data 3316 3316 0 0.0
.text 987468 987468 0 0.0
esp32 all-clusters-app c3devkit (read only) 1202656 1202656 0 0.0
(read/write) 1747176 1747176 0 0.0
.dram0.bss 73568 73568 0 0.0
.dram0.data 13628 13628 0 0.0
.flash.rodata 250456 250456 0 0.0
.flash.text 1202656 1202656 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1244395 1244395 0 0.0
(read/write) 532116 532116 0 0.0
.dram0.bss 80424 80424 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 280592 280592 0 0.0
.flash.text 1238231 1238231 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 611224 611224 0 0.0
(read/write) 81392 81392 0 0.0
.bss 69184 69184 0 0.0
.data 2224 2224 0 0.0
.text 610688 610688 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 696632 696632 0 0.0
.bss 67752 67752 0 0.0
.data 2800 2800 0 0.0
.text 582608 582608 0 0.0
light k32w0+release (read only) 599400 599400 0 0.0
(read/write) 79344 79344 0 0.0
.bss 67160 67160 0 0.0
.data 2200 2200 0 0.0
.text 598864 598864 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 787576 787576 0 0.0
.bss 77428 77428 0 0.0
.data 2016 2016 0 0.0
.text 664680 664680 0 0.0
lock k32w0+release (read only) 581888 581888 0 0.0
(read/write) 78836 78836 0 0.0
.bss 66704 66704 0 0.0
.data 2148 2148 0 0.0
.text 581352 581352 0 0.0
linux air-purifier-app debug (read only) 2629141 2629141 0 0.0
(read/write) 129376 129376 0 0.0
.bss 46944 46944 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 74248 74248 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 184968 184968 0 0.0
.text 2266309 2266309 0 0.0
all-clusters-app debug (read only) 5873913 5873913 0 0.0
(read/write) 478728 478728 0 0.0
.bss 134064 134064 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 332808 332808 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1360 1360 0 0.0
.rodata 347592 347592 0 0.0
.text 5094083 5094083 0 0.0
all-clusters-minimal-app debug (read only) 5188825 5188825 0 0.0
(read/write) 236576 236576 0 0.0
.bss 128080 128080 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 97080 97080 0 0.0
.dynamic 624 624 0 0.0
.got 5304 5304 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 288154 288154 0 0.0
.text 4665923 4665923 0 0.0
bridge-app debug (read only) 4597217 4597217 0 0.0
(read/write) 217560 217560 0 0.0
.bss 118560 118560 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 86128 86128 0 0.0
.dynamic 624 624 0 0.0
.got 5272 5272 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 228922 228922 0 0.0
.text 4147699 4147699 0 0.0
chip-tool debug (read only) 11974969 11974969 0 0.0
(read/write) 520856 520856 0 0.0
.bss 94296 94296 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 414232 414232 0 0.0
.dynamic 624 624 0 0.0
.got 5776 5776 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 447481 447481 0 0.0
.text 10822563 10822563 0 0.0
chip-tool-ipv6only arm64 (read only) 11471488 11471488 0 0.0
(read/write) 588984 588984 0 0.0
.bss 103320 103320 0 0.0
.data 4480 4480 0 0.0
.data.rel.ro 453976 453976 0 0.0
.dynamic 512 512 0 0.0
.got 20328 20328 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 352988 352988 0 0.0
.text 10231580 10231580 0 0.0
lighting-app debug+rpc+ui (read only) 5518513 5518513 0 0.0
(read/write) 226376 226376 0 0.0
.bss 119512 119512 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 94544 94544 0 0.0
.dynamic 672 672 0 0.0
.got 5888 5888 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 353620 353620 0 0.0
.text 4918195 4918195 0 0.0
lock-app debug (read only) 4675977 4675977 0 0.0
(read/write) 205520 205520 0 0.0
.bss 114064 114064 0 0.0
.data 4096 4096 0 0.0
.data.rel.ro 80632 80632 0 0.0
.dynamic 624 624 0 0.0
.got 5224 5224 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 255386 255386 0 0.0
.text 4207987 4207987 0 0.0
ota-provider-app debug (read only) 4302729 4302729 0 0.0
(read/write) 193776 193776 0 0.0
.bss 113824 113824 0 0.0
.data 4304 4304 0 0.0
.data.rel.ro 69728 69728 0 0.0
.dynamic 624 624 0 0.0
.got 4560 4560 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 207770 207770 0 0.0
.text 3901715 3901715 0 0.0
ota-requestor-app debug (read only) 4418745 4418745 0 0.0
(read/write) 198024 198024 0 0.0
.bss 114720 114720 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 72704 72704 0 0.0
.dynamic 624 624 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 213786 213786 0 0.0
.text 4007427 4007427 0 0.0
shell debug (read only) 2868201 2868201 0 0.0
(read/write) 155784 155784 0 0.0
.bss 62576 62576 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 86040 86040 0 0.0
.dynamic 592 592 0 0.0
.got 4080 4080 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 187360 187360 0 0.0
.text 2508034 2508034 0 0.0
thermostat-no-ble arm64 (read only) 4481472 4481472 0 0.0
(read/write) 247536 247536 0 0.0
.bss 122344 122344 0 0.0
.data 3352 3352 0 0.0
.data.rel.ro 103688 103688 0 0.0
.dynamic 512 512 0 0.0
.got 12216 12216 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 159460 159460 0 0.0
.text 3976684 3976684 0 0.0
tv-app debug (read only) 5645249 5645249 0 0.0
(read/write) 351752 351752 0 0.0
.bss 243872 243872 0 0.0
.data 6496 6496 0 0.0
.data.rel.ro 94088 94088 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 286458 286458 0 0.0
.text 5117155 5117155 0 0.0
tv-casting-app debug (read only) 9851017 9851017 0 0.0
(read/write) 340464 340464 0 0.0
.bss 156624 156624 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 174024 174024 0 0.0
.dynamic 624 624 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 382448 382448 0 0.0
.text 9002915 9002915 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531976 2531976 0 0.0
.bss 220480 220480 0 0.0
.data 5200 5200 0 0.0
.text 1494660 1494660 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1095612 1095612 0 0.0
bss 129969 129969 0 0.0
rodata 111732 111732 0 0.0
text 806100 806100 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1215944 1215944 0 0.0
bss 122107 122107 0 0.0
rodata 141592 141592 0 0.0
text 801728 801728 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046812 1046812 0 0.0
bss 129633 129633 0 0.0
rodata 99388 99388 0 0.0
text 770020 770020 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835288 835288 0 0.0
(read/write) 1789780 1789780 0 0.0
.bss 195396 195396 0 0.0
.data 2656 2656 0 0.0
.text 1583340 1583340 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837624 837624 0 0.0
(read/write) 1715548 1715548 0 0.0
.bss 193084 193084 0 0.0
.data 2632 2632 0 0.0
.text 1511444 1511444 0 0.0
light cy8ckit_062s2_43012 (read only) 844352 844352 0 0.0
(read/write) 1634876 1634876 0 0.0
.bss 186548 186548 0 0.0
.data 2440 2440 0 0.0
.text 1437500 1437500 0 0.0
lock cy8ckit_062s2_43012 (read only) 817152 817152 0 0.0
(read/write) 1667172 1667172 0 0.0
.bss 213748 213748 0 0.0
.data 2440 2440 0 0.0
.text 1442596 1442596 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1124896 1124896 0 0.0
.bss 102376 102376 0 0.0
.data 820 820 0 0.0
.text 637280 637280 0 0.0
lock-app qpg6105+debug (read/write) 1089712 1089712 0 0.0
.bss 98672 98672 0 0.0
.data 840 840 0 0.0
.text 602092 602092 0 0.0
stm32 light STM32WB5MM-DK (read/write) 597269 597269 0 0.0
.bss 128288 128288 0 0.0
.data 676 676 0 0.0
.rodata 78828 78828 0 0.0
.text 379752 379752 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825830 825830 0 0.0
bss 51116 51116 0 0.0
text 617558 617558 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1084356 1084356 0 0.0
bss 100920 100920 0 0.0
text 787626 787626 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1045056 1045056 0 0.0
bss 110028 110028 0 0.0
text 761066 761066 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 907068 907068 0 0.0
bss 93060 93060 0 0.0
text 649726 649726 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 827430 827430 0 0.0
bss 51164 51164 0 0.0
text 619220 619220 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 933696 933696 0 0.0
bss 79204 79204 0 0.0
text 699904 699904 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1068544 1068544 0 0.0
bss 100140 100140 0 0.0
text 773524 773524 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 906724 906724 0 0.0
bss 70668 70668 0 0.0
text 655714 655714 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 924848 924848 0 0.0
bss 92640 92640 0 0.0
text 667618 667618 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 830038 830038 0 0.0
bss 51272 51272 0 0.0
text 622222 622222 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 793760 793760 0 0.0
bss 57472 57472 0 0.0
text 592988 592988 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676856 676856 0 0.0
bss 73640 73640 0 0.0
text 462254 462254 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 828694 828694 0 0.0
bss 51292 51292 0 0.0
text 621574 621574 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 852373 852373 0 0.0
bss 60948 60948 0 0.0
text 636420 636420 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 819348 819348 0 0.0
bss 57760 57760 0 0.0
text 612620 612620 0 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 838804 838804 0 0.0
bss 69576 69576 0 0.0
text 629128 629128 0 0.0

@mergify mergify bot merged commit 598356c into project-chip:master Feb 14, 2024
57 checks passed
raul-marquez-csa pushed a commit to raul-marquez-csa/connectedhomeip that referenced this pull request Feb 16, 2024
@andy31415 @andreilitvin @raul-marquez-csa
Remove some unneeded dependencies from generic-callbacks.h (project-c…
84fb708 
…hip#32051)

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plauric plauric plauric approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andy31415 @jmartinez-silabs @plauric @mkardous-silabs @andreilitvin