-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[THREAD] Bring clear all Srp Client host and Services to the GenericThreadStackManagerImpl #32215
Merged
mergify
merged 5 commits into
project-chip:master
from
jmartinez-silabs:generic_clear_srp_services
Feb 20, 2024
Merged
[THREAD] Bring clear all Srp Client host and Services to the GenericThreadStackManagerImpl #32215
mergify
merged 5 commits into
project-chip:master
from
jmartinez-silabs:generic_clear_srp_services
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the GenericThreadStackManagerImpl
github-actions
bot
added
platform
esp32
freeRTOS
linux
zephyr
telink
tizen
For Tizen platform
silabs
labels
Feb 19, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
February 19, 2024 22:47
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
February 19, 2024 22:47
PR #32215: Size comparison from 73d827c to 1ea35c4 Increases (50 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, k32w, nrfconnect, qpg, stm32, telink)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32215: Size comparison from 73d827c to 87511b9 Increases (22 builds for bl702, bl702l, cc13x4_26x4, cyw30739, k32w, qpg, stm32)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, psoc6, qpg, stm32)
|
Damian-Nordic
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support for other platforms!
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp
Outdated
Show resolved
Hide resolved
arkq
reviewed
Feb 20, 2024
Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com>
arkq
reviewed
Feb 20, 2024
PR #32215: Size comparison from 73d827c to 68e7223 Increases (24 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, k32w, qpg, stm32)
Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, stm32)
|
PR #32215: Size comparison from 73d827c to 6aa8185 Increases (49 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, k32w, nrfconnect, qpg, stm32, telink)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
lpbeliveau-silabs
approved these changes
Feb 20, 2024
bhmanda-silabs
pushed a commit
to bhmanda-silabs/connectedhomeip
that referenced
this pull request
Feb 22, 2024
…hreadStackManagerImpl (project-chip#32215) * Bring the functionality to clear all Srp Client host and Services to the GenericThreadStackManagerImpl * Fix Tizen build * Update src/platform/Tizen/ThreadStackManagerImpl.cpp Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com> * Add method documentation and address comments * Restyled by whitespace --------- Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com> Co-authored-by: Restyled.io <commits@restyled.io>
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
…hreadStackManagerImpl (project-chip#32215) * Bring the functionality to clear all Srp Client host and Services to the GenericThreadStackManagerImpl * Fix Tizen build * Update src/platform/Tizen/ThreadStackManagerImpl.cpp Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com> * Add method documentation and address comments * Restyled by whitespace --------- Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings #31606 feature to The GenericThreadStackManagerImpl.
The functionality remains the same (with the addition of deleting the client key lease also).
However, this requires each platform that uses it, to provide a synchronization mechanism.
I created the Templates
_WaitOnSrpClearAllComplete
and_NotifySrpClearAllComplete
and I provided an implementation for all platforms using the GenericThreadStackManagerImpl. (It is left unimplemented for others)The synchronization mechanism I chose for Zephyr platforms (nordic/telink) and Infineon might not be optional so suggestions are welcome.
The functionality was only tested on the Silabs platform and is currently only used on it also. I am confident it works for all FreeRTOS-based platforms.
I suggest all other thread platform owners take some time to test and use
ClearAllSrpHostAndServices
during their factory-reset sequence.