-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and fix batch command tests in TestCommandInteraction #32288
Merged
mergify
merged 4 commits into
project-chip:master
from
tehampson:migrate-unit-test-to-use-command-sender-to-create-batch-commands
Feb 28, 2024
Merged
Cleanup and fix batch command tests in TestCommandInteraction #32288
mergify
merged 4 commits into
project-chip:master
from
tehampson:migrate-unit-test-to-use-command-sender-to-create-batch-commands
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
February 23, 2024 14:28
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
February 23, 2024 14:28
53 tasks
PR #32288: Size comparison from ef8ee32 to 4348521 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32288: Size comparison from ef8ee32 to ab7cce7 Increases above 0.2%:
Increases (10 builds for bl602, bl702, cyw30739, linux)
Decreases (13 builds for bl602, bl702, bl702l, k32w, linux, qpg)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
approved these changes
Feb 23, 2024
Sarthak-Shaha
added a commit
to Sarthak-Shaha/connectedhomeip_silabs
that referenced
this pull request
Feb 28, 2024
…reflect spec and generated the .matter files Replace hardcoded assumption with one dynamically calculated (project-chip#32291) * Replace hardcoded assumption with one dynamically calculated * Quick Fix * Restyled by whitespace * Restyled by clang-format * Address PR comments --------- Co-authored-by: Restyled.io <commits@restyled.io> Cleanup and fix batch command tests in TestCommandInteraction (project-chip#32288) * Have unit test build batch command using CommandSender * Restyled by clang-format * Fix CI * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sarthak-Shaha
added a commit
to Sarthak-Shaha/connectedhomeip_silabs
that referenced
this pull request
Mar 5, 2024
…reflect spec and generated the .matter files Replace hardcoded assumption with one dynamically calculated (project-chip#32291) * Replace hardcoded assumption with one dynamically calculated * Quick Fix * Restyled by whitespace * Restyled by clang-format * Address PR comments --------- Co-authored-by: Restyled.io <commits@restyled.io> Cleanup and fix batch command tests in TestCommandInteraction (project-chip#32288) * Have unit test build batch command using CommandSender * Restyled by clang-format * Fix CI * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
…t-chip#32288) * Have unit test build batch command using CommandSender * Restyled by clang-format * Fix CI * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestCommandHandlerRejectMultipleCommandsWhenHandlerOnlySupportsOne
. While refactoring, it was noticed that the test was not validating what the name was imply. Refactor test to be inline with name