-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Tracing : Added the fix of data type mismatch while registering the metrics in esp32 tracing framework. #32355
[ESP32] Tracing : Added the fix of data type mismatch while registering the metrics in esp32 tracing framework. #32355
Conversation
PR #32355: Size comparison from 6f621f2 to 66cd550 Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving checkmark because platform-specific code with platform approval ... however I have some questions that I placed in the PR ... the usage of a single mRegistered is suspect.
PR #32355: Size comparison from 6f621f2 to 71f56f4 Increases (47 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32355: Size comparison from 6f621f2 to 4720684 Increases (47 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
…ng the metrics in esp32 tracing framework. (project-chip#32355) * Fixed the type mismatch in the esp32 tracing framework * Removed the heap metrics as insights framework maps traces to heap metrics * addressed review comments * restlyed * Added a check to ensure one type associated with one key * Addressed the further review comments
…ng the metrics in esp32 tracing framework. (project-chip#32355) * Fixed the type mismatch in the esp32 tracing framework * Removed the heap metrics as insights framework maps traces to heap metrics * addressed review comments * restlyed * Added a check to ensure one type associated with one key * Addressed the further review comments
Problem
Change Overview:
Testing