-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NXP][k32w1] Remove the need for extra DAC private key conversion binary #32699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
scripts
platform
labels
Mar 25, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
March 25, 2024 14:43
PR #32699: Size comparison from b1f26f8 to 619ef17 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
arkq
reviewed
Mar 28, 2024
andrei-menzopol
force-pushed
the
k32w1-dac-conv
branch
2 times, most recently
from
March 28, 2024 09:46
abeece3
to
8c8898f
Compare
PR #32699: Size comparison from b30ef3b to 8c8898f Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
andrei-menzopol
force-pushed
the
k32w1-dac-conv
branch
from
March 29, 2024 08:04
8c8898f
to
5bbf9fb
Compare
PR #32699: Size comparison from c89090c to 5bbf9fb Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
andrei-menzopol
force-pushed
the
k32w1-dac-conv
branch
from
April 2, 2024 06:50
5bbf9fb
to
a556eb5
Compare
PR #32699: Size comparison from 6c89640 to a556eb5 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
andrei-menzopol
force-pushed
the
k32w1-dac-conv
branch
from
April 2, 2024 13:29
a556eb5
to
a5de032
Compare
PR #32699: Size comparison from 2537cd6 to a5de032 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
…ext DAC key * Do SSS DAC private key conversion at initialization if needed. * Do not use extra SSS conversion binary anymore. * Add option to use DAC private key in plain text. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
…ivate_key * Using chip_convert_dac_private_key option is not needed anymore. * Use chip_use_plain_dac_key=true for plain-text DAC private key. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
* Using chip_convert_dac_private_key option is not needed anymore, making the jlink script obsolete. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
andrei-menzopol
force-pushed
the
k32w1-dac-conv
branch
from
April 3, 2024 09:07
a5de032
to
42c0449
Compare
PR #32699: Size comparison from a7c9a7b to 42c0449 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
Apr 3, 2024
fast track platform specific changes |
Thank you |
marius-alex-tache
pushed a commit
to NXP/matter
that referenced
this pull request
Apr 29, 2024
… conversion binary (project-chip#32699) * [NXP][k32w1] Add SSS DAC private key conversion at init / Use plain-text DAC key * Do SSS DAC private key conversion at initialization if needed. * Do not use extra SSS conversion binary anymore. * Add option to use DAC private key in plain text. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [NXP][k32w1] Update manufacturing flow to not use chip_convert_dac_private_key * Using chip_convert_dac_private_key option is not needed anymore. * Use chip_use_plain_dac_key=true for plain-text DAC private key. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [NXP][k32w1] Remove example_convert_dac_private_key.jlink * Using chip_convert_dac_private_key option is not needed anymore, making the jlink script obsolete. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * Restyled by prettier-markdown * Restyled by prettier-markdown * Check SSS_ExportBlob return status Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> --------- Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit 15a7070)
marius-alex-tache
pushed a commit
to NXP/matter
that referenced
this pull request
Apr 29, 2024
…vate key conversion binary (project-chip#32699)" This reverts commit 932c21a. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
marius-alex-tache
pushed a commit
to NXP/matter
that referenced
this pull request
Apr 29, 2024
… conversion binary (project-chip#32699) * [NXP][k32w1] Add SSS DAC private key conversion at init / Use plain-text DAC key * Do SSS DAC private key conversion at initialization if needed. * Do not use extra SSS conversion binary anymore. * Add option to use DAC private key in plain text. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [NXP][k32w1] Update manufacturing flow to not use chip_convert_dac_private_key * Using chip_convert_dac_private_key option is not needed anymore. * Use chip_use_plain_dac_key=true for plain-text DAC private key. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [NXP][k32w1] Remove example_convert_dac_private_key.jlink * Using chip_convert_dac_private_key option is not needed anymore, making the jlink script obsolete. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * Restyled by prettier-markdown * Restyled by prettier-markdown * Check SSS_ExportBlob return status Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> --------- Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit 15a7070)
GabrielCouturier
pushed a commit
to NXP/matter
that referenced
this pull request
Oct 31, 2024
… conversion binary (project-chip#32699) * [NXP][k32w1] Add SSS DAC private key conversion at init / Use plain-text DAC key * Do SSS DAC private key conversion at initialization if needed. * Do not use extra SSS conversion binary anymore. * Add option to use DAC private key in plain text. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [NXP][k32w1] Update manufacturing flow to not use chip_convert_dac_private_key * Using chip_convert_dac_private_key option is not needed anymore. * Use chip_use_plain_dac_key=true for plain-text DAC private key. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [NXP][k32w1] Remove example_convert_dac_private_key.jlink * Using chip_convert_dac_private_key option is not needed anymore, making the jlink script obsolete. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * Restyled by prettier-markdown * Restyled by prettier-markdown * Check SSS_ExportBlob return status Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> --------- Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit 15a7070)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
fast track
platform
review - pending
scripts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application will check at initialization whether the DAC private key has been
converted or not and convert it if needed. There is no need for an extra binary.