-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ble-WiFi commissioning test in CI - dockerfile #32890
Conversation
e6a0d8f
to
4d05420
Compare
PR #32890: Size comparison from f46cdf3 to 4d05420 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
4d05420
to
8e3dab2
Compare
PR #32890: Size comparison from f29ccbe to 8e3dab2 Decreases (1 build for efr32)
Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
&& rm -rf /var/lib/apt/lists/* \ | ||
&& rm -rf /var/cache/apt/* \ | ||
&& : # last line | ||
COPY --from=build-env ${UBUNTU_QEMU_DIR} ${UBUNTU_QEMU_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try to place every possible build and sdk into chip-build-vscode
. Should this be done for the qemu image as well or is it too large or not viable to run in the chip-build-vscode image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The size of layers added to ghcr.io/project-chip/chip-build is about 400Mb. I feel like we can add it to chip-build-vscode. I just didn't think about it earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as a stand-alone image creation. Maybe we can place the new image in chip-build-vscode in the future in case we want to run qemu tests in that image as well.
This is a docker image required for related PR #32889