-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple android CHIP IM APIs from CHIPController to separate CHIPInteractionModel lib #32978
Merged
yunhanw-google
merged 7 commits into
project-chip:master
from
sharadb-amazon:droid-intmodel-20240412
Apr 13, 2024
Merged
Decouple android CHIP IM APIs from CHIPController to separate CHIPInteractionModel lib #32978
yunhanw-google
merged 7 commits into
project-chip:master
from
sharadb-amazon:droid-intmodel-20240412
Apr 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
April 12, 2024 21:01
pullapprove
bot
requested review from
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
April 12, 2024 21:01
PR #32978: Size comparison from 1601e05 to bdca786 Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
PR #32978: Size comparison from 1601e05 to e0dd735 Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
sharadb-amazon
force-pushed
the
droid-intmodel-20240412
branch
from
April 12, 2024 22:23
e0dd735
to
2373630
Compare
PR #32978: Size comparison from 2dd3bfd to 2373630 Full report (4 builds for cc32xx, mbed, stm32)
|
sharadb-amazon
force-pushed
the
droid-intmodel-20240412
branch
from
April 12, 2024 22:37
2373630
to
f63a1a8
Compare
PR #32978: Size comparison from 2dd3bfd to f63a1a8 Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, nxp, qpg, stm32)
|
yunhanw-google
approved these changes
Apr 12, 2024
sharadb-amazon
force-pushed
the
droid-intmodel-20240412
branch
from
April 12, 2024 23:18
f63a1a8
to
6de4b88
Compare
joonhaengHeo
approved these changes
Apr 12, 2024
PR #32978: Size comparison from 2dd3bfd to 6de4b88 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #32978: Size comparison from 2dd3bfd to f4ba9e4 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #32978: Size comparison from 2dd3bfd to 75ce179 Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
PR #32978: Size comparison from 2dd3bfd to c12d7c9 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #32977
Change summary
Testing
Tested by building the examples/tv-casting-app and seeing that the CHIPInteractionModel gets built in.