-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Compilation fix when IPV4 is disabled. #33085
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33085: Size comparison from b4650b9 to 7b32efe Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
reviewed
Apr 22, 2024
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple and
kkasperczyk-no
June 21, 2024 04:33
shripad621git
force-pushed
the
fix/disable_ipv4
branch
from
June 21, 2024 04:34
7b32efe
to
3f85107
Compare
PR #33085: Size comparison from 9d56786 to 3f85107 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
github-actions
bot
added
documentation
Improvements or additions to documentation
config
labels
Jun 21, 2024
shripad621git
force-pushed
the
fix/disable_ipv4
branch
2 times, most recently
from
June 21, 2024 06:42
76d43f2
to
c0c62a2
Compare
PR #33085: Size comparison from 9d56786 to c0c62a2 Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
shripad621git
force-pushed
the
fix/disable_ipv4
branch
from
June 21, 2024 07:04
c0c62a2
to
4720921
Compare
shubhamdp
approved these changes
Jun 21, 2024
Co-authored-by: Shubham Patil <shubham.patil@espressif.com>
Co-authored-by: Shubham Patil <shubham.patil@espressif.com>
PR #33085: Size comparison from 9d56786 to 4048e57 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #33085: Size comparison from 9d56786 to f2d9c42 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jun 21, 2024
shripad621git
force-pushed
the
fix/disable_ipv4
branch
from
June 21, 2024 12:31
f2d9c42
to
26ea0ef
Compare
PR #33085: Size comparison from bf7e9fc to 26ea0ef Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shripad621git
force-pushed
the
fix/disable_ipv4
branch
from
June 21, 2024 14:21
26ea0ef
to
d73dbbf
Compare
PR #33085: Size comparison from 2af3379 to d73dbbf Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shripad621git
force-pushed
the
fix/disable_ipv4
branch
from
June 24, 2024 06:53
d73dbbf
to
a03d2a6
Compare
PR #33085: Size comparison from 07ac2f1 to a03d2a6 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
approved these changes
Jul 1, 2024
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
* Compilation fix when IPV4 is disabled. * Addressed review comments and documented the IPv4 disabled change * Update docs/guides/esp32/config_options.md Co-authored-by: Shubham Patil <shubham.patil@espressif.com> * Update docs/guides/esp32/config_options.md Co-authored-by: Shubham Patil <shubham.patil@espressif.com> * Resolved the build failure for m5-stack ipv6 only test --------- Co-authored-by: Shubham Patil <shubham.patil@espressif.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config
documentation
Improvements or additions to documentation
esp32
examples
platform
review - approved
scripts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The compilation failed when
CONFIG_DISABLE_IPV4=y
andCONFIG_LWIP_IPV4=n
were set through menuconfig as mentioned here.Same failure was observed in building connectedhomeip esp32 examples with these above options.
Change Overview:
Fixed the compilation for IPV4 for ESP32.
Testing
Tested the lighting-app esp32 with above options enabled.