-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Eliminate ZCLReadAttribute/ZCLSend #33428
[Python] Eliminate ZCLReadAttribute/ZCLSend #33428
Conversation
5d94829
to
b8fc7e3
Compare
PR #33428: Size comparison from 0180ee6 to b8fc7e3 Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33428: Size comparison from 0180ee6 to e8336e5 Increases above 0.2%:
Increases (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (4 builds for psoc6)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Afaict, the Darwin Tests failure are unrelated to this change (also happen on master from time to time). |
Remove ZCLReadAttribute and ZCLSend API use from the level control test TestLevelControlCluster and convert to asyncio.
Remove ZCLReadAttribute API use from basic information cluster test and convert to use asyncio.
Avoid using ZCLSend API instead use SendCommand directly in the send_zcl_command helper function.
Remove ZCLSend API usage and call SendCommand directly. Also convert the test to a test using asyncio.
Remove ZCLSend API usage and call SendCommand directly. Also convert the test to a test using asyncio.
The class is no longer required. Test results are tested directly.
e8336e5
to
e434f78
Compare
e434f78
to
138a686
Compare
PR #33428: Size comparison from 878fbb7 to 138a686 Decreases (2 builds for efr32)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
It seems TestWriteBasicAttributes did not correctly write the attributes. The broad exception handling seems to have hidden this issue even. Make sure the attributes with the correct value get written, and check for unexpected and expected IM errors in the per-attribute results specifically.
PR #33428: Size comparison from 878fbb7 to fd30b24 Increases (3 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33428: Size comparison from 878fbb7 to 90c50e4 Increases (16 builds for bl602, bl702, bl702l, linux, nrfconnect, nxp)
Decreases (19 builds for bl702l, efr32, esp32, linux)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33428: Size comparison from 878fbb7 to 33cedd7 Increases (16 builds for bl602, bl702, bl702l, linux, nrfconnect, nxp)
Decreases (19 builds for bl702l, efr32, esp32, linux)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to remove these from ChipDeviceCtrl as well?
Yes, along with |
This eliminates use of ZCLReadAttribute and ZCLSend and improves some tests using asyncio.