-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wi-Fi Network Management Cluster and use correct NIM device type id #33519
Merged
ksperling-apple
merged 8 commits into
project-chip:master
from
ksperling-apple:wifi-network-management-cluster
May 29, 2024
Merged
Add Wi-Fi Network Management Cluster and use correct NIM device type id #33519
ksperling-apple
merged 8 commits into
project-chip:master
from
ksperling-apple:wifi-network-management-cluster
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
examples
scripts
darwin
controller
app
github
workflows
labels
May 20, 2024
PR #33519: Size comparison from 443bb9c to 3b1e64c Increases (16 builds for linux)
Decreases (3 builds for efr32, esp32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
May 20, 2024 05:58
pullapprove
bot
requested review from
woody-apple,
younghak-hwang and
yunhanw-google
May 20, 2024 05:58
ksperling-apple
force-pushed
the
wifi-network-management-cluster
branch
from
May 20, 2024 21:58
3b1e64c
to
165ea58
Compare
PR #33519: Size comparison from 6bd80b0 to 165ea58 Increases (16 builds for linux)
Decreases (3 builds for efr32, esp32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
src/app/clusters/wifi-network-management-server/wifi-network-management-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/wifi-network-management-server/wifi-network-management-server.cpp
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/wifi-network-management-cluster.xml
Outdated
Show resolved
Hide resolved
ksperling-apple
force-pushed
the
wifi-network-management-cluster
branch
from
May 23, 2024 11:11
b34948a
to
6c59f6a
Compare
PR #33519: Size comparison from c3ef110 to 6c59f6a Increases (16 builds for linux)
Decreases (3 builds for efr32, esp32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
May 23, 2024
andy31415
reviewed
May 23, 2024
src/app/clusters/wifi-network-management-server/wifi-network-management-server.h
Outdated
Show resolved
Hide resolved
andy31415
reviewed
May 23, 2024
src/app/clusters/wifi-network-management-server/wifi-network-management-server.cpp
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
May 23, 2024
ksperling-apple
force-pushed
the
wifi-network-management-cluster
branch
2 times, most recently
from
May 27, 2024 05:41
42438c8
to
1cc7a86
Compare
PR #33519: Size comparison from 3718e99 to 1cc7a86 Increases (16 builds for linux)
Decreases (3 builds for efr32, esp32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
- Factor out HaveNetworkCredentials() helper and use it consistently - Validate WPA credential in SetNetworkCredentials() - Don't emit an SSID change when only the passphrase changes - Use CHIPSafeCasts - Avoid std::bind (and we can't use std::bind_front yet) - Add a destructor that unregisters handlers
- Rename Server -> WiFiNetworkManagementServer and move it up a namespace. - Move internal definitions into an anonymous namespace.
ksperling-apple
force-pushed
the
wifi-network-management-cluster
branch
from
May 29, 2024 01:04
1cc7a86
to
5d04085
Compare
PR #33519: Size comparison from 8c8889b to 5d04085 Increases (16 builds for linux)
Decreases (2 builds for esp32, linux)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
documentation
Improvements or additions to documentation
examples
github
review - approved
scripts
workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Wi-Fi Network Management Cluster XML and implementation.
Implement the cluster in the network-manager-app example (with hard-coded data for now).
Use the correct assigned device type id for the NIM.
Change the minimal-build job to build the network-manage-app.