Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FANCTRL] Fix enums #33874

Merged
merged 6 commits into from
Jun 12, 2024
Merged

[FANCTRL] Fix enums #33874

merged 6 commits into from
Jun 12, 2024

Conversation

rbultman
Copy link
Contributor

@rbultman rbultman commented Jun 12, 2024 •
edited
Loading

This PR removes the slashes in the enum names for fan control.

Spec PR here: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/9369

Fixes #33857

@github-actions github-actions bot added the app label Jun 12, 2024
@rbultman rbultman marked this pull request as ready for review June 12, 2024 13:28
@rbultman rbultman requested review from cecille and andy31415 June 12, 2024 13:28
@rbultman rbultman requested a review from vivien-apple June 12, 2024 13:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

PR #33874: Size comparison from dc8187b to 246d380

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section dc8187b 246d380 change % change
bl602 lighting-app bl602 FLASH 1268298 1268298 0 0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1282576 1282576 0 0.0
RAM 95576 95576 0 0.0
bl602+rpc FLASH 1307256 1307256 0 0.0
RAM 103856 103856 0 0.0
bl702 lighting-app bl702 FLASH 1088938 1088938 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099888 1099888 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1179018 1179018 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872114 872114 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1124146 1124146 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1076080 1076080 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1087342 1087342 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797596 797596 0 0.0
RAM 103184 103184 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813392 813392 0 0.0
RAM 113664 113664 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802756 802756 0 0.0
RAM 107784 107784 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755244 755244 0 0.0
RAM 101884 101884 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 740900 740900 0 0.0
RAM 102132 102132 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 604846 604846 0 0.0
RAM 204608 204608 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650634 650634 0 0.0
RAM 204868 204868 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661253 661253 0 0.0
RAM 74608 74608 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681105 681105 0 0.0
RAM 77240 77240 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681105 681105 0 0.0
RAM 77240 77240 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638033 638033 0 0.0
RAM 69676 69676 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603429 603429 0 0.0
RAM 70312 70312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623073 623073 0 0.0
RAM 72864 72864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623073 623073 0 0.0
RAM 72864 72864 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619221 619221 0 0.0
RAM 73328 73328 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638945 638945 0 0.0
RAM 75880 75880 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638945 638945 0 0.0
RAM 75880 75880 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587469 587469 0 0.0
RAM 67296 67296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607313 607313 0 0.0
RAM 69928 69928 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607313 607313 0 0.0
RAM 69928 69928 0 0.0
efr32 lighting-app BRD4187C FLASH 887832 887832 0 0.0
RAM 183520 183520 0 0.0
lock-app BRD4338a FLASH 701672 701664 -8 -0.0
RAM 242804 242804 0 0.0
window-app BRD4187C FLASH 968748 968740 -8 -0.0
RAM 167952 167952 0 0.0
esp32 all-clusters-app c3devkit DRAM 88420 88420 0 0.0
FLASH 1466214 1466214 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114892 114892 0 0.0
FLASH 1535431 1535431 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4568 4568 0 0.0
FLASH 2531872 2531872 0 0.0
RAM 129104 129104 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5568430 5568430 0 0.0
RAM 483032 483032 0 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5052216 5052216 0 0.0
RAM 236824 236824 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4477544 4477544 0 0.0
RAM 216784 216784 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11511111 11511111 0 0.0
RAM 535234 535234 0 0.0
chip-tool-ipv6only arm64 unknown 19792 19792 0 0.0
FLASH 10649364 10649364 0 0.0
RAM 583232 583232 0 0.0
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 1128125 1128125 0 0.0
RAM 528818 528818 0 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4347160 4347160 0 0.0
RAM 208832 208832 0 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5365586 5365586 0 0.0
RAM 225424 225424 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4542904 4542904 0 0.0
RAM 204240 204240 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4177128 4177128 0 0.0
RAM 193200 193200 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4301576 4301576 0 0.0
RAM 197840 197840 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2799997 2799997 0 0.0
RAM 154424 154424 0 0.0
thermostat-no-ble arm64 unknown 9160 9160 0 0.0
FLASH 4149444 4149444 0 0.0
RAM 234584 234584 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5587192 5587192 0 0.0
RAM 345672 345672 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9559094 9559094 0 0.0
RAM 352832 352832 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497748 1497748 0 0.0
RAM 226168 226168 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 873828 873828 0 0.0
RAM 139225 139225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 948512 948512 0 0.0
RAM 137653 137653 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 821804 821804 0 0.0
RAM 138123 138123 0 0.0
nxp contact k32w0+release FLASH 575220 575220 0 0.0
RAM 70120 70120 0 0.0
k32w1+release FLASH 590464 590464 0 0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 609216 609216 0 0.0
RAM 69596 69596 0 0.0
k32w1+release FLASH 673648 673648 0 0.0
RAM 82904 82904 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1610156 1610156 0 0.0
RAM 207228 207228 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534356 1534356 0 0.0
RAM 204132 204132 0 0.0
light cy8ckit_062s2_43012 FLASH 1460652 1460652 0 0.0
RAM 197412 197412 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462948 1462948 0 0.0
RAM 224476 224476 0 0.0
qpg lighting-app qpg6105+debug FLASH 650216 650216 0 0.0
RAM 104652 104652 0 0.0
lock-app qpg6105+debug FLASH 610196 610196 0 0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 472124 472124 0 0.0
RAM 141748 141748 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625098 625098 0 0.0
RAM 49952 49952 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 600692 600692 0 0.0
RAM 130384 130384 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770308 770308 0 0.0
RAM 110148 110148 0 0.0
bridge-app tlsr9258a FLASH 668228 668228 0 0.0
RAM 94768 94768 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626850 626850 0 0.0
RAM 49996 49996 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 712688 712688 0 0.0
RAM 76588 76588 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 557830 557830 0 0.0
RAM 126640 126640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 792896 792896 0 0.0
RAM 99996 99996 0 0.0
lock-app-dfu tlsr9528a FLASH 660154 660154 0 0.0
RAM 69276 69276 0 0.0
ota-requestor-app tlsr9258a FLASH 686564 686564 0 0.0
RAM 94492 94492 0 0.0
pump-app tlsr9518adk80d FLASH 609050 609050 0 0.0
RAM 56376 56376 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599398 599398 0 0.0
RAM 56176 56176 0 0.0
shell tlsr9518adk80d FLASH 462618 462618 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633244 633244 0 0.0
RAM 51624 51624 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642236 642236 0 0.0
RAM 59812 59812 0 0.0
thermostat tlsr9518adk80d FLASH 618300 618300 0 0.0
RAM 56500 56500 0 0.0
window-covering tlsr9118bdk40d FLASH 464616 464616 0 0.0
RAM 82272 82272 0 0.0
tizen all-clusters-app arm unknown 1548 1548 0 0.0
FLASH 1612776 1612776 0 0.0
RAM 45412 45412 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 15735202 15735202 0 0.0
RAM 6902256 6902256 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

PR #33874: Size comparison from dc8187b to 9410f4a

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section dc8187b 9410f4a change % change
bl602 lighting-app bl602 FLASH 1268298 1267874 -424 -0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1282576 1282152 -424 -0.0
RAM 95576 95576 0 0.0
bl602+rpc FLASH 1307256 1306832 -424 -0.0
RAM 103856 103856 0 0.0
bl702 lighting-app bl702 FLASH 1088938 1088514 -424 -0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099888 1099464 -424 -0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1179018 1178594 -424 -0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872114 872114 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1124146 1123710 -436 -0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1076080 1075656 -424 -0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1087342 1086918 -424 -0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797596 797580 -16 -0.0
RAM 103184 103184 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813392 813384 -8 -0.0
RAM 113664 113664 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802756 802748 -8 -0.0
RAM 107784 107784 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755244 755236 -8 -0.0
RAM 101884 101884 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 740900 740884 -16 -0.0
RAM 102132 102132 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 604846 604846 0 0.0
RAM 204608 204608 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650634 650634 0 0.0
RAM 204868 204868 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661253 661093 -160 -0.0
RAM 74608 74608 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681105 680945 -160 -0.0
RAM 77240 77240 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681105 680945 -160 -0.0
RAM 77240 77240 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638033 637873 -160 -0.0
RAM 69676 69676 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603429 603269 -160 -0.0
RAM 70312 70312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623073 622913 -160 -0.0
RAM 72864 72864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623073 622913 -160 -0.0
RAM 72864 72864 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619221 619061 -160 -0.0
RAM 73328 73328 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638945 638785 -160 -0.0
RAM 75880 75880 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638945 638785 -160 -0.0
RAM 75880 75880 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587469 587309 -160 -0.0
RAM 67296 67296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607313 607153 -160 -0.0
RAM 69928 69928 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607313 607153 -160 -0.0
RAM 69928 69928 0 0.0
efr32 lighting-app BRD4187C FLASH 887832 887696 -136 -0.0
RAM 183520 183520 0 0.0
lock-app BRD4338a FLASH 701672 701520 -152 -0.0
RAM 242804 242804 0 0.0
window-app BRD4187C FLASH 968748 968564 -184 -0.0
RAM 167952 167952 0 0.0
esp32 all-clusters-app c3devkit DRAM 88420 88420 0 0.0
FLASH 1466214 1466046 -168 -0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114892 114892 0 0.0
FLASH 1535431 1535279 -152 -0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4568 4568 0 0.0
FLASH 2531872 2531616 -256 -0.0
RAM 129104 129072 -32 -0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5568430 5568174 -256 -0.0
RAM 483032 483000 -32 -0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5052216 5051960 -256 -0.0
RAM 236824 236792 -32 -0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4477544 4477288 -256 -0.0
RAM 216784 216752 -32 -0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11511111 11510855 -256 -0.0
RAM 535234 535202 -32 -0.0
chip-tool-ipv6only arm64 unknown 19792 19792 0 0.0
FLASH 10649364 10649092 -272 -0.0
RAM 583232 583200 -32 -0.0
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 1128125 11280999 -256 -0.0
RAM 528818 528786 -32 -0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4347160 4346904 -256 -0.0
RAM 208832 208800 -32 -0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5365586 5365330 -256 -0.0
RAM 225424 225392 -32 -0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4542904 4542648 -256 -0.0
RAM 204240 204208 -32 -0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4177128 4177128 0 0.0
RAM 193200 193200 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4301576 4301576 0 0.0
RAM 197840 197840 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2799997 2799741 -256 -0.0
RAM 154424 154392 -32 -0.0
thermostat-no-ble arm64 unknown 9160 9160 0 0.0
FLASH 4149444 4149444 0 0.0
RAM 234584 234584 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5587192 5586936 -256 -0.0
RAM 345672 345640 -32 -0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9559094 9558838 -256 -0.0
RAM 352832 352800 -32 -0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497748 1497340 -408 -0.0
RAM 226168 226168 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 873828 873800 -28 -0.0
RAM 139225 139225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 948512 948500 -12 -0.0
RAM 137653 137653 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 821804 821776 -28 -0.0
RAM 138123 138123 0 0.0
nxp contact k32w0+release FLASH 575220 575212 -8 -0.0
RAM 70120 70120 0 0.0
k32w1+release FLASH 590464 590320 -144 -0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 609216 609160 -56 -0.0
RAM 69596 69596 0 0.0
k32w1+release FLASH 673648 673496 -152 -0.0
RAM 82904 82904 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1610156 1609988 -168 -0.0
RAM 207228 207228 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534356 1534212 -144 -0.0
RAM 204132 204132 0 0.0
light cy8ckit_062s2_43012 FLASH 1460652 1460484 -168 -0.0
RAM 197412 197412 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462948 1462780 -168 -0.0
RAM 224476 224476 0 0.0
qpg lighting-app qpg6105+debug FLASH 650216 650072 -144 -0.0
RAM 104652 104652 0 0.0
lock-app qpg6105+debug FLASH 610196 610052 -144 -0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 472124 471972 -152 -0.0
RAM 141748 141748 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625098 625094 -4 -0.0
RAM 49952 49952 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 600692 600692 0 0.0
RAM 130384 130384 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770308 770304 -4 -0.0
RAM 110148 110148 0 0.0
bridge-app tlsr9258a FLASH 668228 668224 -4 -0.0
RAM 94768 94768 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626850 626846 -4 -0.0
RAM 49996 49996 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 712688 712684 -4 -0.0
RAM 76588 76588 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 557830 557830 0 0.0
RAM 126640 126640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 792896 792892 -4 -0.0
RAM 99996 99996 0 0.0
lock-app-dfu tlsr9528a FLASH 660154 660150 -4 -0.0
RAM 69276 69276 0 0.0
ota-requestor-app tlsr9258a FLASH 686564 686560 -4 -0.0
RAM 94492 94492 0 0.0
pump-app tlsr9518adk80d FLASH 609050 609046 -4 -0.0
RAM 56376 56376 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599398 599394 -4 -0.0
RAM 56176 56176 0 0.0
shell tlsr9518adk80d FLASH 462618 462614 -4 -0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633244 633240 -4 -0.0
RAM 51624 51624 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642236 642232 -4 -0.0
RAM 59812 59812 0 0.0
thermostat tlsr9518adk80d FLASH 618300 618296 -4 -0.0
RAM 56500 56500 0 0.0
window-covering tlsr9118bdk40d FLASH 464616 464616 0 0.0
RAM 82272 82272 0 0.0
tizen all-clusters-app arm unknown 1548 1548 0 0.0
FLASH 1612776 1612704 -72 -0.0
RAM 45412 45412 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 15735202 15735130 -72 -0.0
RAM 6902256 6902256 0 0.0

@bzbarsky-apple bzbarsky-apple mentioned this pull request Jun 12, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

PR #33874: Size comparison from 018ef92 to 3922431

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 018ef92 3922431 change % change
bl602 lighting-app bl602 FLASH 1267874 1267874 0 0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1282152 1282152 0 0.0
RAM 95576 95576 0 0.0
bl602+rpc FLASH 1306832 1306832 0 0.0
RAM 103856 103856 0 0.0
bl702 lighting-app bl702 FLASH 1088514 1088514 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099464 1099464 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1178594 1178594 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872114 872114 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1123710 1123710 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1075656 1075656 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1086918 1086918 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797580 797580 0 0.0
RAM 103184 103184 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813384 813384 0 0.0
RAM 113664 113664 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802748 802748 0 0.0
RAM 107784 107784 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755236 755236 0 0.0
RAM 101884 101884 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 740884 740884 0 0.0
RAM 102132 102132 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 604846 604846 0 0.0
RAM 204608 204608 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650634 650634 0 0.0
RAM 204868 204868 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661093 661093 0 0.0
RAM 74608 74608 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680945 680945 0 0.0
RAM 77240 77240 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680945 680945 0 0.0
RAM 77240 77240 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 637873 637873 0 0.0
RAM 69676 69676 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603269 603269 0 0.0
RAM 70312 70312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 622913 622913 0 0.0
RAM 72864 72864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 622913 622913 0 0.0
RAM 72864 72864 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619061 619061 0 0.0
RAM 73328 73328 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638785 638785 0 0.0
RAM 75880 75880 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638785 638785 0 0.0
RAM 75880 75880 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587309 587309 0 0.0
RAM 67296 67296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607153 607153 0 0.0
RAM 69928 69928 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607153 607153 0 0.0
RAM 69928 69928 0 0.0
efr32 lighting-app BRD4187C FLASH 887696 887696 0 0.0
RAM 183520 183520 0 0.0
lock-app BRD4338a FLASH 701520 701520 0 0.0
RAM 242804 242804 0 0.0
window-app BRD4187C FLASH 968564 968564 0 0.0
RAM 167952 167952 0 0.0
esp32 all-clusters-app c3devkit DRAM 88420 88420 0 0.0
FLASH 1466046 1466046 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114892 114892 0 0.0
FLASH 1535279 1535279 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4568 4568 0 0.0
FLASH 2531616 2531616 0 0.0
RAM 129072 129072 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5568174 5568174 0 0.0
RAM 483000 483000 0 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5051960 5051960 0 0.0
RAM 236792 236792 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4477288 4477288 0 0.0
RAM 216752 216752 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11510855 11510855 0 0.0
RAM 535202 535202 0 0.0
chip-tool-ipv6only arm64 unknown 19792 19792 0 0.0
FLASH 10649092 10649092 0 0.0
RAM 583200 583200 0 0.0
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 11280999 11280999 0 0.0
RAM 528786 528786 0 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4346904 4346904 0 0.0
RAM 208800 208800 0 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5365330 5365330 0 0.0
RAM 225392 225392 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4542648 4542648 0 0.0
RAM 204208 204208 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4177128 4177128 0 0.0
RAM 193200 193200 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4301576 4301576 0 0.0
RAM 197840 197840 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2799741 2799741 0 0.0
RAM 154392 154392 0 0.0
thermostat-no-ble arm64 unknown 9160 9160 0 0.0
FLASH 4149444 4149444 0 0.0
RAM 234584 234584 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5586936 5586936 0 0.0
RAM 345640 345640 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9558838 9558838 0 0.0
RAM 352800 352800 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497340 1497340 0 0.0
RAM 226168 226168 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 873800 873800 0 0.0
RAM 139225 139225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 948500 948500 0 0.0
RAM 137653 137653 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 821776 821776 0 0.0
RAM 138123 138123 0 0.0
nxp contact k32w0+release FLASH 575212 575212 0 0.0
RAM 70120 70120 0 0.0
k32w1+release FLASH 590320 590320 0 0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 609160 609160 0 0.0
RAM 69596 69596 0 0.0
k32w1+release FLASH 673496 673496 0 0.0
RAM 82904 82904 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1609988 1609988 0 0.0
RAM 207228 207228 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534212 1534212 0 0.0
RAM 204132 204132 0 0.0
light cy8ckit_062s2_43012 FLASH 1460484 1460484 0 0.0
RAM 197412 197412 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462780 1462780 0 0.0
RAM 224476 224476 0 0.0
qpg lighting-app qpg6105+debug FLASH 650072 650072 0 0.0
RAM 104652 104652 0 0.0
lock-app qpg6105+debug FLASH 610052 610052 0 0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 471972 471972 0 0.0
RAM 141748 141748 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625094 625094 0 0.0
RAM 49952 49952 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 600692 600692 0 0.0
RAM 130384 130384 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770304 770304 0 0.0
RAM 110148 110148 0 0.0
bridge-app tlsr9258a FLASH 668224 668224 0 0.0
RAM 94768 94768 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626846 626846 0 0.0
RAM 49996 49996 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 712684 712684 0 0.0
RAM 76588 76588 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 557830 557830 0 0.0
RAM 126640 126640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 792892 792892 0 0.0
RAM 99996 99996 0 0.0
lock-app-dfu tlsr9528a FLASH 660150 660150 0 0.0
RAM 69276 69276 0 0.0
ota-requestor-app tlsr9258a FLASH 686560 686560 0 0.0
RAM 94492 94492 0 0.0
pump-app tlsr9518adk80d FLASH 609046 609046 0 0.0
RAM 56376 56376 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599394 599394 0 0.0
RAM 56176 56176 0 0.0
shell tlsr9518adk80d FLASH 462614 462614 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633240 633240 0 0.0
RAM 51624 51624 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642232 642232 0 0.0
RAM 59812 59812 0 0.0
thermostat tlsr9518adk80d FLASH 618296 618296 0 0.0
RAM 56500 56500 0 0.0
window-covering tlsr9118bdk40d FLASH 464616 464616 0 0.0
RAM 82272 82272 0 0.0
tizen all-clusters-app arm unknown 1548 1548 0 0.0
FLASH 1612704 1612704 0 0.0
RAM 45412 45412 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 15735130 15735130 0 0.0
RAM 6902256 6902256 0 0.0

@mergify mergify bot merged commit 0ae8a02 into project-chip:master Jun 12, 2024
68 checks passed
@rbultman rbultman deleted the fixFanControlEnum branch June 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 andy31415 approved these changes

@cecille cecille Awaiting requested review from cecille

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.3] All values of FanModeSequenceEnum in FanControl cluster are Off
4 participants
@rbultman @andy31415 @saurabhst @bzbarsky-apple