[Python] Make Commissioning APIs more pythonic and consistent #33905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #33905: Size comparison from f0bf341 to 1463fc7 Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
agners
force-pushed
the
cleanup-commissioning-api-error-handling
branch
from
1463fc7 to
940e0d9
Compare
|
PR #33905: Size comparison from 540c991 to 940e0d9 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
agners
force-pushed
the
cleanup-commissioning-api-error-handling
branch
from
940e0d9 to
fc4baeb
Compare
|
PR #33905: Size comparison from cc66da8 to fc4baeb Full report (3 builds for cc32xx, stm32)
|
agners
force-pushed
the
cleanup-commissioning-api-error-handling
branch
from
fc4baeb to
dd8a0da
Compare
agners
changed the title
|
PR #33905: Size comparison from cc66da8 to dd8a0da Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
agners
force-pushed
the
cleanup-commissioning-api-error-handling
branch
2 times, most recently
from
910e9fe to
d528865
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran and
hawk248
|
PR #33905: Size comparison from 8ba371a to 94a516b Full report (9 builds for cc32xx, mbed, nrfconnect, stm32, tizen)
|
agners
force-pushed
the
cleanup-commissioning-api-error-handling
branch
from
94a516b to
2cc79da
Compare
|
PR #33905: Size comparison from 8ba371a to 2cc79da Full report (22 builds for cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
agners
force-pushed
the
cleanup-commissioning-api-error-handling
branch
from
2cc79da to
44c05b2
Compare
|
PR #33905: Size comparison from 8ba371a to 44c05b2 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
agners
force-pushed
the
cleanup-commissioning-api-error-handling
branch
from
44c05b2 to
26cd4d0
Compare
|
PR #33905: Size comparison from 8ba371a to 26cd4d0 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
agners
force-pushed
the
cleanup-commissioning-api-error-handling
branch
from
26cd4d0 to
3fa711e
Compare
|
PR #33905: Size comparison from 4cdce52 to 3fa711e Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This commit makes the commissioning APIs more pythonic and consistent by not returning PyChipError but simply raising ChipStackError exceptions on errors instead. The return value instead returns the effectively assigned node ID as defined by the NOC. If the SDK ends up generating that NOC, it will use the thing passed to PairDevice, so those will match with what is provided when calling the commissioning API.
agners
force-pushed
the
cleanup-commissioning-api-error-handling
branch
from
3fa711e to
2e404b4
Compare
|
FYI, I've rebased this on top of master to get the changes from #33954. This makes the implementation of |
agners
changed the title
|
PR #33905: Size comparison from ab2907b to 2e404b4 Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
agners
force-pushed
the
cleanup-commissioning-api-error-handling
branch
2 times, most recently
from
5769b3c to
4aa8413
Compare
|
PR #33905: Size comparison from 6cf8de8 to 4aa8413 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
agners
force-pushed
the
cleanup-commissioning-api-error-handling
branch
from
4aa8413 to
281a293
Compare
|
PR #33905: Size comparison from eeac38f to 281a293 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This was referenced Jun 18, 2024
diogopintodsr
pushed a commit
to diogopintodsr/connectedhomeip
that referenced
this pull request
Jun 20, 2024
…t-chip#33905) * [Python] Make Commissioning APIs more pythonic and consistent This commit makes the commissioning APIs more pythonic and consistent by not returning PyChipError but simply raising ChipStackError exceptions on errors instead. The return value instead returns the effectively assigned node ID as defined by the NOC. If the SDK ends up generating that NOC, it will use the thing passed to PairDevice, so those will match with what is provided when calling the commissioning API. * [Python] Adjust tests to use new commissioning error handling
agners
added a commit
to agners/chip-wheels
that referenced
this pull request
Jun 20, 2024
This adds commissioning API updates from the master branch to our 1.3 based branch. This makes the commissioning API more Pythonic and allows to call them from the asyncio event loop directly. Specifically, this integrates changes from the following PRs - project-chip/connectedhomeip#33954 - project-chip/connectedhomeip#33905 - project-chip/connectedhomeip#34011 - project-chip/connectedhomeip#34001 - project-chip/connectedhomeip#33989
agners
added a commit
to home-assistant-libs/chip-wheels
that referenced
this pull request
Jun 20, 2024
This adds commissioning API updates from the master branch to our 1.3 based branch. This makes the commissioning API more Pythonic and allows to call them from the asyncio event loop directly. Specifically, this integrates changes from the following PRs - project-chip/connectedhomeip#33954 - project-chip/connectedhomeip#33905 - project-chip/connectedhomeip#34001 - project-chip/connectedhomeip#33989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the commissioning APIs more pythonic and consistent by not returning PyChipError but simply raising ChipStackError exceptions instead.