-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics] Added additional metrics for CASE and Subscription #33934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anush-apple
commented
Jun 14, 2024
- CASE session tracking
- Subscription Setup
- MRP Retries
tcarmelveilleux
approved these changes
Jun 14, 2024
pullapprove
bot
requested review from
andyg-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple and
kkasperczyk-no
June 14, 2024 21:33
pullapprove
bot
requested review from
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
June 14, 2024 21:33
woody-apple
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending comments
anush-apple
force-pushed
the
case-metrics
branch
from
June 14, 2024 22:40
8c17176
to
0313cab
Compare
PR #33934: Size comparison from a12a0c0 to 69e63dd Full report (11 builds for esp32, mbed, nrfconnect, nxp, stm32)
|
- CASE session tracking - Subscription Setup - MRP Retries
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
anush-apple
force-pushed
the
case-metrics
branch
from
June 18, 2024 20:02
8f53f12
to
f8902c3
Compare
PR #33934: Size comparison from b6e1a48 to 1abed8d Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
diogopintodsr
pushed a commit
to diogopintodsr/connectedhomeip
that referenced
this pull request
Jun 20, 2024
…-chip#33934) * [Metrics] Added additional metrics for CASE and Subscription - CASE session tracking - Subscription Setup - MRP Retries * Fixed code review comment * Restyler fixes * Update src/darwin/Framework/CHIP/MTRDevice.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Addressed code review comments * Update src/darwin/Framework/CHIP/MTRMetricKeys.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Fixed build failure when tracing is off * Resytle fixes --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.