[ESP32] Replaced FreeRTOS timer with CHIP timers in nimble BLEManagerImpl. #34050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PR #34050: Size comparison from 7c04979 to 19dc105 Full report (32 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34050: Size comparison from 7c04979 to 08a2f0b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jun 24, 2024
|
PR #34050: Size comparison from 686e73b to b99dd17 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jun 25, 2024
shubhamdp
pushed a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Jun 28, 2024
…Impl. (project-chip#34050) * Replace free RTOS timer with ChipTimer * Replaced FreeRTOS timer with CHIP timer
andy31415
pushed a commit
that referenced
this pull request
Jun 28, 2024
* [ESP32] Replaced FreeRTOS timer with CHIP timers in nimble BLEManagerImpl. (#34050) * Replace free RTOS timer with ChipTimer * Replaced FreeRTOS timer with CHIP timer * ESP32: Fixes in BLEManager (#34082) - Fix the ble re-advertisement if invalid bytes are written on the characteristic. - cancel the ble advertisement timer on ble connection - remove the unnecessary if check * Fix crash for eps32 commissioner if ble disconnect during commissioning (#33332) --------- Co-authored-by: Mahesh <92411857+pimpalemahesh@users.noreply.github.com> Co-authored-by: cdj <45139296+DejinChen@users.noreply.github.com>
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…Impl. (project-chip#34050) * Replace free RTOS timer with ChipTimer * Replaced FreeRTOS timer with CHIP timer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The issue was a crash occurring with the message:
bleAdv Timeout: Start slow advertisement
ERROR A stack overflow in task Tmr Svc has been detected.
This crash was caused by a stack overflow in the FreeRTOS timer.
Change Overview
To resolve the stack overflow issue, the FreeRTOS timer has been replaced with a CHIP Timer in the BleManagerImpl file. Additionally, some code optimization changes were made.
Testing
The changes were tested on the following chips:
ESP32
ESP32-C3
ESP32-S3
The testing included scenarios for fast, slow, and extended advertisement.