Remove queued presets from Thermostats #34090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
nivi-apple
force-pushed
the
remove_queued_preset_from_sdk
branch
from
504eec0 to
d71a363
Compare
|
PR #34090: Size comparison from 6a72fd1 to bf9f16e Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
@nivi-apple please add some description in the PR summary of why |
nivi-apple
force-pushed
the
remove_queued_preset_from_sdk
branch
from
bf9f16e to
eaf2973
Compare
|
PR #34090: Size comparison from 27a653c to b8f3182 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34090: Size comparison from 27a653c to ed05043 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34090: Size comparison from 10b67ad to f76fe99 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
approved these changes
Jul 23, 2024
bzbarsky-apple
approved these changes
Jul 23, 2024
|
@andy31415 Please see #34090 (comment) |
|
PR #34090: Size comparison from 10b67ad to aaf77be Full report (17 builds for cc13x4_26x4, cc32xx, mbed, nxp, qpg, stm32, tizen)
|
|
PR #34090: Size comparison from 10b67ad to 6daaa2e Increases above 0.2%:
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jul 24, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Rebase to tip of tree * Regenerated the zap files * Generated zap files on tip of tree * Remove queued struct keywords from Darwin * Remove CancelSetActivePresetRequest from Darwin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #34089
The PR has skip-protocol-compatibility due to the fact that some of the attributes are not marked provisional in the xml when they should be. The attributes are not implemented yet. However since they are not marked provisional we need to add the skip-protocol-compatibility so API compatibility checker passes. These are the attributes that were removed -
Thermostat::SetActivePresetRequestRequest has field changes
Bitmap Feature removed entry kQueuedPresetsSupported
Command Thermostat::CancelSetActivePresetRequest was removed
Attribute Thermostat::QueuedPreset has been deleted.
For the Thermostat::QueuedPresetStruct, it was marked provisional but we still saw errors and an issue was filed for that - #34091