Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP32] Fix the bluedroid build issue on ESP32. #34133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ESP32] Fix the bluedroid build issue on ESP32. #34133

wants to merge 1 commit into from
+118 −18

Conversation

shripad621git
Copy link
Contributor

@shripad621git shripad621git commented Jun 28, 2024 •
edited
Loading

Problem:

  • Build with Bluedroid was failing on ESP32 examples.

Change Overview

  • Fixed the build issue with bluedroid.
  • Added extended ble advertising support.
  • Added a TODO for Bluedroid Shutdown flow.

Testing

  • Tested the lighting app esp32 with bluedroid flow for esp32 and esp32c3.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

PR #34133: Size comparison from 0460715 to fb343cb

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 0460715 fb343cb change % change
bl602 lighting-app bl602 FLASH 1270644 1270644 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284902 1284902 0 0.0
RAM 95472 95472 0 0.0
bl602+rpc FLASH 1309860 1309860 0 0.0
RAM 103752 103752 0 0.0
bl702 lighting-app bl702 FLASH 1091790 1091790 0 0.0
RAM 15161 15161 0 0.0
bl702+mfd FLASH 1102484 1102484 0 0.0
RAM 15313 15313 0 0.0
bl702+rpc FLASH 1181600 1181600 0 0.0
RAM 24181 24181 0 0.0
bl706-eth FLASH 874884 874884 0 0.0
RAM 27272 27272 0 0.0
bl706-wifi FLASH 1127216 1127216 0 0.0
RAM 14605 14605 0 0.0
bl702l lighting-app bl702l FLASH 1078676 1078676 0 0.0
RAM 21732 21732 0 0.0
bl702l+mfd FLASH 1089938 1089938 0 0.0
RAM 21892 21892 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798296 798296 0 0.0
RAM 103096 103096 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814052 814052 0 0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803568 803568 0 0.0
RAM 107696 107696 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 756360 756360 0 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 742040 742040 0 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605842 605842 0 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650870 650870 0 0.0
RAM 204780 204780 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 666065 666065 0 0.0
RAM 75100 75100 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 685909 685909 0 0.0
RAM 77732 77732 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 685909 685909 0 0.0
RAM 77732 77732 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 642845 642845 0 0.0
RAM 70168 70168 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608609 608609 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628245 628245 0 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628245 628245 0 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 624113 624113 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643837 643837 0 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643837 643837 0 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 592677 592677 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 612529 612529 0 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 612529 612529 0 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 923220 923220 0 0.0
RAM 134996 134996 0 0.0
lock-app BRD4338a FLASH 762148 762148 0 0.0
RAM 174552 174552 0 0.0
window-app BRD4187C FLASH 1012040 1012040 0 0.0
RAM 129616 129616 0 0.0
esp32 all-clusters-app c3devkit DRAM 88332 88332 0 0.0
FLASH 1468744 1468744 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114796 114796 0 0.0
FLASH 1537959 1537959 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4592 4592 0 0.0
FLASH 2529216 2529216 0 0.0
RAM 125112 125112 0 0.0
all-clusters-app debug unknown 5368 5368 0 0.0
FLASH 5581246 5581246 0 0.0
RAM 487384 487384 0 0.0
all-clusters-minimal-app debug unknown 5288 5288 0 0.0
FLASH 5051432 5051432 0 0.0
RAM 232936 232936 0 0.0
bridge-app debug unknown 5256 5256 0 0.0
FLASH 4477464 4477464 0 0.0
RAM 212832 212832 0 0.0
chip-tool debug unknown 5728 5728 0 0.0
FLASH 11688023 11688023 0 0.0
RAM 542018 542018 0 0.0
chip-tool-ipv6only arm64 unknown 19992 19992 0 0.0
FLASH 10806732 10806732 0 0.0
RAM 590928 590928 0 0.0
fabric-admin debug unknown 5592 5592 0 0.0
FLASH 10653303 10653303 0 0.0
RAM 535658 535658 0 0.0
fabric-bridge-app debug unknown 5264 5264 0 0.0
FLASH 4348008 4348008 0 0.0
RAM 204960 204960 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5373058 5373058 0 0.0
RAM 221640 221640 0 0.0
lock-app debug unknown 5192 5192 0 0.0
FLASH 4541016 4541016 0 0.0
RAM 200248 200248 0 0.0
ota-provider-app debug unknown 4576 4576 0 0.0
FLASH 4196904 4196904 0 0.0
RAM 194544 194544 0 0.0
ota-requestor-app debug unknown 4512 4512 0 0.0
FLASH 4322264 4322264 0 0.0
RAM 199168 199168 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2794525 2794525 0 0.0
RAM 150480 150480 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4167580 4167580 0 0.0
RAM 235864 235864 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5602984 5602984 0 0.0
RAM 341800 341800 0 0.0
tv-casting-app debug unknown 5096 5096 0 0.0
FLASH 9859646 9859646 0 0.0
RAM 400024 400024 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502116 1502116 0 0.0
RAM 226656 226656 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 881088 881088 0 0.0
RAM 139693 139693 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 951688 951688 0 0.0
RAM 138121 138121 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 826644 826644 0 0.0
RAM 138591 138591 0 0.0
nxp contact k32w0+release FLASH 575868 575868 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 591032 591032 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609960 609960 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 674536 674536 0 0.0
RAM 82816 82816 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613436 1613436 0 0.0
RAM 207148 207148 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534204 1534204 0 0.0
RAM 204052 204052 0 0.0
light cy8ckit_062s2_43012 FLASH 1461076 1461076 0 0.0
RAM 197332 197332 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462932 1462932 0 0.0
RAM 224396 224396 0 0.0
qpg lighting-app qpg6105+debug FLASH 650876 650876 0 0.0
RAM 104564 104564 0 0.0
lock-app qpg6105+debug FLASH 611000 611000 0 0.0
RAM 99240 99240 0 0.0
stm32 light STM32WB5MM-DK FLASH 472272 472272 0 0.0
RAM 141652 141652 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632372 632372 0 0.0
RAM 50528 50528 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 657052 657052 0 0.0
RAM 145872 145872 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 777346 777346 0 0.0
RAM 110684 110684 0 0.0
bridge-app tlsr9258a FLASH 675364 675364 0 0.0
RAM 95304 95304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 633956 633956 0 0.0
RAM 50572 50572 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 719758 719758 0 0.0
RAM 77148 77148 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 612186 612186 0 0.0
RAM 142104 142104 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 799966 799966 0 0.0
RAM 100508 100508 0 0.0
lock-app-dfu tlsr9528a FLASH 665528 665528 0 0.0
RAM 69860 69860 0 0.0
ota-requestor-app tlsr9258a FLASH 694694 694694 0 0.0
RAM 95028 95028 0 0.0
pump-app tlsr9518adk80d FLASH 616228 616228 0 0.0
RAM 56952 56952 0 0.0
pump-controller-app tlsr9518adk80d FLASH 606612 606612 0 0.0
RAM 56752 56752 0 0.0
shell tlsr9518adk80d FLASH 466192 466192 0 0.0
RAM 72484 72484 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 640316 640316 0 0.0
RAM 52200 52200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 650438 650438 0 0.0
RAM 60388 60388 0 0.0
thermostat tlsr9518adk80d FLASH 625502 625502 0 0.0
RAM 57084 57084 0 0.0
window-covering tlsr9118bdk40d FLASH 518734 518734 0 0.0
RAM 97800 97800 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1633324 1633324 0 0.0
RAM 46012 46012 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16110190 16110190 0 0.0
RAM 7079696 7079696 0 0.0

@shubhamdp shubhamdp mentioned this pull request Dec 12, 2024
Open
@shripad621git shripad621git force-pushed the fix/bluedroid_build branch 2 times, most recently from f21f3ee to 651e5de Compare December 20, 2024 07:22
@shripad621git shripad621git marked this pull request as ready for review December 20, 2024 07:22
@shripad621git shripad621git requested a review from a team as a code owner December 20, 2024 07:22
@shripad621git shripad621git changed the title [ESP32] BLeManager Implementation changes for bluedroid. [ESP32] BleManager Implementation changes for bluedroid. Dec 20, 2024
@shripad621git shripad621git changed the title [ESP32] BleManager Implementation changes for bluedroid. [ESP32] Fix the bluedroid build issue on ESP32. Dec 20, 2024
@shripad621git
Fixed the bluedroid build issue in ESP32
2633dd2 
- Fixed the build issue with bluedroid.
- Added extended ble advertising support.
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

PR #34133: Size comparison from c1afc02 to 2633dd2

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section c1afc02 2633dd2 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1354136 1354136 0 0.0
RAM 104160 104160 0 0.0
bl702 lighting-app bl702+eth FLASH 651682 651682 0 0.0
RAM 25353 25353 0 0.0
bl702+wifi FLASH 829286 829286 0 0.0
RAM 14093 14093 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057758 1057758 0 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 978876 978876 0 0.0
RAM 16596 16596 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839840 839840 0 0.0
RAM 123696 123696 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825380 825380 0 0.0
RAM 125584 125584 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772208 772208 0 0.0
RAM 114060 114060 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756388 756388 0 0.0
RAM 114260 114260 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 539705 539705 0 0.0
RAM 205800 205800 0 0.0
lock CC3235SF_LAUNCHXL FLASH 573873 573873 0 0.0
RAM 205944 205944 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681401 681401 0 0.0
RAM 78756 78756 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701253 701253 0 0.0
RAM 81396 81396 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701253 701253 0 0.0
RAM 81396 81396 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658181 658181 0 0.0
RAM 73824 73824 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618025 618025 0 0.0
RAM 71748 71748 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637653 637653 0 0.0
RAM 74292 74292 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637653 637653 0 0.0
RAM 74292 74292 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637425 637425 0 0.0
RAM 74756 74756 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657133 657133 0 0.0
RAM 77300 77300 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657133 657133 0 0.0
RAM 77300 77300 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614045 614045 0 0.0
RAM 68844 68844 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633897 633897 0 0.0
RAM 71476 71476 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633897 633897 0 0.0
RAM 71476 71476 0 0.0
efr32 lock-app BRD4187C FLASH 932324 932324 0 0.0
RAM 160228 160228 0 0.0
BRD4338a FLASH 746744 746736 -8 -0.0
RAM 233356 233356 0 0.0
window-app BRD4187C FLASH 1025176 1025176 0 0.0
RAM 128332 128332 0 0.0
esp32 all-clusters-app c3devkit DRAM 95352 95352 0 0.0
FLASH 1541440 1541440 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116332 116332 0 0.0
FLASH 1547898 1547898 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2716981 2716981 0 0.0
RAM 130120 130120 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6009782 6009782 0 0.0
RAM 523816 523816 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5347104 5347104 0 0.0
RAM 242904 242904 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4686672 4686672 0 0.0
RAM 218752 218752 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12846546 12846546 0 0.0
RAM 582594 582594 0 0.0
chip-tool-ipv6only arm64 unknown 21360 21360 0 0.0
FLASH 10980944 10980944 0 0.0
RAM 633536 633536 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11253095 11253095 0 0.0
RAM 582946 582946 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4511908 4511908 0 0.0
RAM 205920 205920 0 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5608613 5608613 0 0.0
RAM 472888 472888 0 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5622513 5622513 0 0.0
RAM 229080 229080 0 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4735064 4735064 0 0.0
RAM 205064 205064 0 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4361618 4361618 0 0.0
RAM 198752 198752 0 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4500644 4500644 0 0.0
RAM 203336 203336 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3033645 3033645 0 0.0
RAM 160736 160736 0 0.0
thermostat-no-ble arm64 unknown 9560 9560 0 0.0
FLASH 4105728 4105728 0 0.0
RAM 243344 243344 0 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5957893 5957893 0 0.0
RAM 596304 596304 0 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11056637 11056637 0 0.0
RAM 692600 692600 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917744 917744 0 0.0
RAM 143332 143332 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890452 890452 0 0.0
RAM 141519 141519 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851808 851808 0 0.0
RAM 142244 142244 0 0.0
nxp contact k32w0+release FLASH 585600 585600 0 0.0
RAM 71112 71112 0 0.0
mcxw71+release FLASH 600136 600136 0 0.0
RAM 63208 63208 0 0.0
light k32w0+release FLASH 612348 612348 0 0.0
RAM 70504 70504 0 0.0
k32w1+release FLASH 686560 686560 0 0.0
RAM 48840 48840 0 0.0
lock mcxw71+release FLASH 762880 762880 0 0.0
RAM 70876 70876 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647068 1647068 0 0.0
RAM 212128 212128 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1554716 1554716 0 0.0
RAM 208944 208944 0 0.0
light cy8ckit_062s2_43012 FLASH 1469820 1469820 0 0.0
RAM 200912 200912 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467540 1467540 0 0.0
RAM 225272 225272 0 0.0
qpg lighting-app qpg6105+debug FLASH 663968 663968 0 0.0
RAM 105456 105456 0 0.0
lock-app qpg6105+debug FLASH 621796 621796 0 0.0
RAM 99908 99908 0 0.0
stm32 light STM32WB5MM-DK FLASH 484712 484712 0 0.0
RAM 144912 144912 0 0.0
telink bridge-app tlsr9258a FLASH 683176 683176 0 0.0
RAM 91248 91248 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623416 623416 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772328 772328 0 0.0
RAM 49348 49348 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710858 710858 0 0.0
RAM 73544 73544 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627862 627862 0 0.0
RAM 142180 142180 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813880 813880 0 0.0
RAM 99724 99724 0 0.0
tizen all-clusters-app arm unknown 5000 5000 0 0.0
FLASH 1735204 1735204 0 0.0
RAM 90888 90888 0 0.0
chip-tool-ubsan arm unknown 10808 10808 0 0.0
FLASH 17969006 17969006 0 0.0
RAM 7841376 7841376 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
esp32 platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shripad621git