fixing type hints errors on python controller code #34415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #34415: Size comparison from d62f5a6 to 34f3009 Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
Alami-Amine
force-pushed
the
AA/mypy_fixes
branch
from
34f3009 to
16abf43
Compare
|
PR #34415: Size comparison from d62f5a6 to 16abf43 Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
Alami-Amine
force-pushed
the
AA/mypy_fixes
branch
from
16abf43 to
1ac1e79
Compare
|
PR #34415: Size comparison from d62f5a6 to f28ddb5 Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
Alami-Amine
force-pushed
the
AA/mypy_fixes
branch
from
0576e59 to
12bb98e
Compare
Alami-Amine
force-pushed
the
AA/mypy_fixes
branch
from
1e9b929 to
23ace52
Compare
Alami-Amine
changed the title
Alami-Amine
changed the title
Alami-Amine
changed the title
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn and
Damian-Nordic
Alami-Amine
force-pushed
the
AA/mypy_fixes
branch
from
bc402af to
89613a7
Compare
|
PR #34415: Size comparison from f6022e4 to 2b1dd69 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/mypy_fixes
branch
from
2eb5639 to
7c0d57d
Compare
|
PR #34415: Size comparison from 63959ca to 7c0d57d Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/mypy_fixes
branch
2 times, most recently
from
9f579e2 to
aa72c01
Compare
|
PR #34415: Size comparison from 10b67ad to aa72c01 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
Yes, please let's update mypy. It is safe to use a newer version, even the latest version supports older Python versions (down to Python 3.7 it seems). So updating mypy can only improve checking 👍
Does that mean we can get rid of the subscriptable pointer type work around? If so, I definitly go for mypy upgrade in this PR, and drop the work around. If we still need the work around, we can update mypy in a separate PR. |
|
agners
previously requested changes
Jul 24, 2024
There was a problem hiding this comment.
In general, fixing/improving type hints is very welcome, so thank you for the PR 🙏
It is a bit hard to review currently due to the additional wrapping. Can you reformat again with line-lenght set to 132?
One thing I'd like to consider is bumping the minimal Python version at one point. It really gets interesting with Python 3.10 PEP 604, but maybe it is a bit early for that.
Alami-Amine
force-pushed
the
AA/mypy_fixes
branch
from
aa72c01 to
06268b5
Compare
Alami-Amine
force-pushed
the
AA/mypy_fixes
branch
from
06268b5 to
8945625
Compare
Alami-Amine
force-pushed
the
AA/mypy_fixes
branch
from
36298b7 to
55d9b9c
Compare
|
PR #34415: Size comparison from 48be002 to 55d9b9c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Aug 1, 2024
w8floosh
pushed a commit
to w8floosh/chip-fuzzing
that referenced
this pull request
Aug 4, 2024
* fixing mypy errors * restyled * add new files to BUILD.gn * mypy: fixing p256keypair.py * more mypy fixes * adding workaround to allow type hinting ctypes pointers * more mypy fixes * more mypy fixes * Restyled by autopep8 --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in preparation of releasing chip python modules on PyPi,
mypyis being run on the code to ensure compliance with type hint and annotation standards (such as PEP 484)UPDATE (Changes included):
awaitinChipDeviceCtrl.py:221propertyfromChipDeviceControllerBase__init__of dataclass EventHeader__init__of dataclass TypedAttributePath to__post_init__