-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-IDM-10.2: Add tests for choice conformance #34445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds functions to evaluate conformance on elements (features, attributes and commands). Tests: - unit tests included - tested on all-clusters-app, and all-clusters-app with switch feature conformance changed to be incorrect.
PR #34445: Size comparison from a10b47d to 4d8c534 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
July 22, 2024 19:22
pullapprove
bot
requested review from
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
July 22, 2024 19:22
PR #34445: Size comparison from a10b47d to 73883c3 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 23, 2024
andy31415
reviewed
Jul 23, 2024
andy31415
approved these changes
Jul 23, 2024
Co-authored-by: Andrei Litvin <andy314@gmail.com>
PR #34445: Size comparison from a10b47d to c1f47e6 Increases above 0.2%:
Full report (4 builds for mbed, nrfconnect)
|
jmartinez-silabs
approved these changes
Jul 25, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* TC-IDM-10.2: Add tests for choice conformance Adds functions to evaluate conformance on elements (features, attributes and commands). Tests: - unit tests included - tested on all-clusters-app, and all-clusters-app with switch feature conformance changed to be incorrect. * styling and linter * Restyled by autopep8 * Restyled by isort * Apply suggestions from code review Co-authored-by: Andrei Litvin <andy314@gmail.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Andrei Litvin <andy314@gmail.com>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* TC-IDM-10.2: Add tests for choice conformance Adds functions to evaluate conformance on elements (features, attributes and commands). Tests: - unit tests included - tested on all-clusters-app, and all-clusters-app with switch feature conformance changed to be incorrect. * styling and linter * Restyled by autopep8 * Restyled by isort * Apply suggestions from code review Co-authored-by: Andrei Litvin <andy314@gmail.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Andrei Litvin <andy314@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functions to evaluate conformance on elements (features, attributes and commands).
Tests: