Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Area: Remove nullable qualities to match the latest spec #34732

Merged
merged 36 commits into from
Aug 6, 2024
Merged

Service Area: Remove nullable qualities to match the latest spec #34732

merged 36 commits into from
Aug 6, 2024

Conversation

hicklin
Copy link
Contributor

@hicklin hicklin commented Aug 2, 2024 •
edited
Loading

Fixes #34669.

This PR

  • Removes the nullabel quality form the SupportedAreas, SupportedMaps, SelectedAreas and Progress attributes.
  • Updates the encoding on these attributes.
  • Removes the nullabel quality form the NewAreas argument in the SelectAreas command.
  • Updates some logic.

hicklin and others added 30 commits July 31, 2024 17:04
@hicklin
Updated the golabl data type's XMLs, removing the cluster entries.
e4087bd
@hicklin
Zap generated after XML update.
7342db3
@hicklin
Fixed namespaces used of global structs.
63edf2e
@restyled-commits @hicklin
Restyled by clang-format
1cab752
@hicklin
Renamed LocationInfoStruct to AreaInfoStruct.
72de6c5
@hicklin
Zap generated after XML update.
f2add10
@hicklin
Renamed LocationStruct to AreaStruct and its LocationID and LocationD…
c6134a6 
…esc fields.
@hicklin
Zap generated after XML update.
af8b02c
@hicklin
Updated SDK and example code to match the new naming.
a20d803
@hicklin
Updated the ProgressStruct's LocationID name to AreaID.
8bb0d34
@hicklin
Zap generated after XML update.
5bd0285
@hicklin
Updated the SDK code following name changes.
5dc5eb0
@hicklin
Updated the SelectLocationsStatus and SkipLocationStatus enum names a…
5429771 
…nd some of their enums.
@hicklin
Zap generated after XML update.
04e87b6
@hicklin
Updated the SelectLocationsStatus and SkipCurrentLocationStatus names…
91f4446 
… and their enum names.
@hicklin
Updated the names of the SupportedLocations, SelectedLocations and Cu…
31a3c1a 
…rrentLocation attributes.
@hicklin
Zap generated after XML update.
f7d6a54
@hicklin
Updated the changed names in the SDK.
4c128e6
@hicklin
Updated the service area command names in XML.
088f01d
@hicklin
Zap generated after XML update.
a6b8036
@hicklin
Updated the service area command names in the SDK.
69eb53f
@hicklin
Updated the rvc-example zap file.
c6c3659
@hicklin
Refactored LocationStructureWrapper to AreaStructureWrapper.
d378b4e
@hicklin
Merge branch 'master' into update_names
75a3369
@restyled-commits @hicklin
Restyled by clang-format
86c38ed
@hicklin
Regenerated zap files due to changes upsteram.
a611a5b
@hicklin
Merge branch 'master' into update_names
56d0184
@hicklin
Removed unused generated file.
b3abfbd
@hicklin
Updated the Service Area XML marking previously nullabel attributes a…
e82a96e 
…s not-nullable.
@hicklin
Zap generated after XML update.
f48fb79
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

PR #34732: Size comparison from c53d771 to cd43089

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section c53d771 cd43089 change % change
bl602 lighting-app bl602 FLASH 1277798 1277798 0 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292056 1292056 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1317014 1317014 0 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1098938 1098938 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109888 1109888 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189004 1189004 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 881972 881972 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135150 1135150 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086100 1086100 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097362 1097362 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802792 802792 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818628 818628 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810904 810904 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763244 763244 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747768 747768 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610502 610502 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654774 654774 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671905 671905 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691757 691757 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691757 691757 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648693 648693 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610409 610409 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627761 627761 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 599861 599861 0 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 619713 619713 0 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 619713 619713 0 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929864 929856 -8 -0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737116 737108 -8 -0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015508 1015508 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94136 94136 0 0.0
FLASH 1530592 1530592 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115072 115072 0 0.0
FLASH 1541114 1541130 16 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2746431 2746431 0 0.0
RAM 128368 128368 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 6027940 6027940 0 0.0
RAM 509904 509904 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5367894 5367894 0 0.0
RAM 240000 240000 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4727640 4727640 0 0.0
RAM 217024 217024 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12496364 12470692 -25672 -0.2
RAM 558362 557946 -416 -0.1
chip-tool-ipv6only arm64 unknown 20352 20328 -24 -0.1
FLASH 11173852 11149484 -24368 -0.2
RAM 608320 607904 -416 -0.1
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11474607 11453913 -20694 -0.2
RAM 555098 554682 -416 -0.1
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4483232 4483232 0 0.0
RAM 202192 202192 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5661713 5661713 0 0.0
RAM 228112 228112 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4782040 4782040 0 0.0
RAM 203840 203840 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4422354 4422354 0 0.0
RAM 197824 197824 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4560962 4560962 0 0.0
RAM 202360 202360 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3067117 3067117 0 0.0
RAM 158952 158952 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4357300 4357300 0 0.0
RAM 242216 242216 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6004917 6004917 0 0.0
RAM 583552 583552 0 0.0
tv-casting-app debug unknown 5176 5176 0 0.0
FLASH 10700797 10674797 -26000 -0.2
RAM 645608 645064 -544 -0.1
mbed lock-app-release cy8cproto_062_4343w FLASH 1505732 1505732 0 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 906924 906924 0 0.0
RAM 142225 142225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 879520 879520 0 0.0
RAM 140364 140364 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 838676 838676 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 576700 576700 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592408 592408 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612424 612424 0 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 677376 677376 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1636044 1636044 0 0.0
RAM 210912 210912 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1541244 1541244 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463508 1463508 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462156 1462156 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612912 612912 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477928 477928 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619742 619742 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 678578 678578 0 0.0
RAM 149556 149556 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 771842 771842 0 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678444 678444 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621334 621334 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707198 707198 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620198 620198 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806284 806284 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654076 654076 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696478 696478 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630778 630778 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608290 608290 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628102 628102 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652112 652112 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 631874 631874 0 0.0
RAM 53376 53376 0 0.0
window-covering tlsr9118bdk40d FLASH 522252 522252 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1705388 1705388 0 0.0
RAM 51820 51820 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16619530 16576970 -42560 -0.3
RAM 7303816 7281288 -22528 -0.3

@mergify mergify bot merged commit e58e16e into project-chip:master Aug 6, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiel-apple kiel-apple kiel-apple approved these changes

@plauric plauric plauric approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@plauric plauric

Labels
app controller darwin examples review - approved
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the nullable quality of ServiceArea list attributes
4 participants
@hicklin @plauric @kiel-apple @restyled-commits