Credential modification should check type, not just index. #34841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credential indices are per-type, so we should be checking both when locating the credential to be modified. Fixes project-chip#34816
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34841: Size comparison from 587665d to 96fcd9a Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Aug 7, 2024
|
Tagging Critical Quality fix so we release note this, this causes us to update the wrong credentials (since we don't check types) |
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
…hip#34841) Credential indices are per-type, so we should be checking both when locating the credential to be modified. Fixes project-chip#34816
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Aug 19, 2024
Credential indices are per-type, so we should be checking both when locating the credential to be modified. This is a backport of project-chip#34841 to the 1.3 branch.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Aug 19, 2024
Credential indices are per-type, so we should be checking both when locating the credential to be modified. This is a backport of project-chip#34841 to the 1.2 branch.
andy31415
pushed a commit
that referenced
this pull request
Aug 30, 2024
Credential indices are per-type, so we should be checking both when locating the credential to be modified. This is a backport of #34841 to the 1.3 branch.
andy31415
pushed a commit
that referenced
this pull request
Aug 30, 2024
Credential indices are per-type, so we should be checking both when locating the credential to be modified. This is a backport of #34841 to the 1.2 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credential indices are per-type, so we should be checking both when locating the credential to be modified.
Fixes #34816