OpenThread: clear the previous srp host and services when connecting … #35065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
|
PR #35065: Size comparison from b823a29 to 3e9e9db Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
DejinChen
force-pushed
the
clear_previous_srp_host_and_services
branch
2 times, most recently
from
72f1cba
to
b52f512
Compare
|
PR #35065: Size comparison from 5bff3a5 to b52f512 Full report (75 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
DejinChen
force-pushed
the
clear_previous_srp_host_and_services
branch
from
b52f512
to
8634375
Compare
|
PR #35065: Size comparison from 5bff3a5 to 8634375 Full report (10 builds for nrfconnect, nxp, qpg, stm32)
|
|
PR #35065: Size comparison from 5bff3a5 to dd9b3b0 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.h
Outdated
Show resolved
Hide resolved
src/platform/OpenThread/GenericNetworkCommissioningThreadDriver.cpp
Outdated
Show resolved
Hide resolved
DejinChen
force-pushed
the
clear_previous_srp_host_and_services
branch
from
dd9b3b0
to
3e9e9db
Compare
|
PR #35065: Size comparison from 41be641 to 3e9e9db Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Damian-Nordic
approved these changes
Sep 3, 2024
andy31415
approved these changes
Sep 9, 2024
|
PR #35065: Size comparison from 86e1974 to 8c43425 Full report (67 builds for cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
DejinChen
force-pushed
the
clear_previous_srp_host_and_services
branch
from
8c43425
to
a9b2ea2
Compare
|
PR #35065: Size comparison from 60d6c6b to a9b2ea2 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent duplicated srp services, clear the previous srp host and services when connecting to a new network.