Update ColorControl bounds based on spec fixes #35156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
tcarmelveilleux
commented
Aug 22, 2024
github-actions
bot
added
examples
scripts
app
tests
matter-1.4-te2-script-change
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro and
cliffamzn
pullapprove
bot
requested review from
turon,
younghak-hwang,
vivien-apple,
yufengwangca,
wiba-nordic,
yunhanw-google and
woody-apple
|
PR #35156: Size comparison from 58896ab to 01ece15 Full report (60 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
cecille
approved these changes
Aug 22, 2024
jmartinez-silabs
approved these changes
Aug 23, 2024
bzbarsky-apple
approved these changes
Aug 23, 2024
|
PR #35156: Size comparison from acba7f8 to c302299 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35156: Size comparison from acba7f8 to dc03786 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ReneJosefsen
approved these changes
Aug 27, 2024
PeterC1965
pushed a commit
to PeterC1965/connectedhomeip
that referenced
this pull request
Aug 28, 2024
* Update color defaults in samples * Update color control server logic to avoid div-by-zero * Update TC-CC-2.1 with new bounds on ColorControl * Restyled by clang-format * More fixes to CI * Set default startup mireds to null * Fix some comments * Try to fix CI --------- Co-authored-by: Restyled.io <commits@restyled.io>
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
* Update color defaults in samples * Update color control server logic to avoid div-by-zero * Update TC-CC-2.1 with new bounds on ColorControl * Restyled by clang-format * More fixes to CI * Set default startup mireds to null * Fix some comments * Try to fix CI --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Minimum color temperature bounds in spec were too wide and included
a value for ColorTempPhysicalMinMireds that could lead to divide-by-zero
in examples (and it did).
The spec has been fixed (https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10202) and test plan updated to avoid the zero value (https://github.com/CHIP-Specifications/chip-test-plans/pull/4545).
This PR
attributes are written to invalid values.
Testing done