update_cluster_revisions.py excludes updating no-unique-id example's BINFO cluster #35510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e apps BINFO cluster
|
Review changes with SemanticDiff. Analyzed 1 of 1 files.
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
approved these changes
Sep 10, 2024
|
PR #35510: Size comparison from 0140a72 to 78fa371 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
saurabhst
approved these changes
Sep 10, 2024
tehampson
commented
Sep 10, 2024
bzbarsky-apple
approved these changes
Sep 10, 2024
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
PR #35510: Size comparison from 0140a72 to 590a624 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…BINFO cluster (project-chip#35510) --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lighting-app-data-mode-no-unique-idintentionally has a BINFO cluster revision set to 3 to be compliant with not providing a UniqueID that became mandatory in cluster revision 4.Test:
python3 scripts/tools/zap/update_cluster_revisions.py --dry-run --cluster-id 0x0039 --new-revision 4 | grep no-uniquepython3 scripts/tools/zap/update_cluster_revisions.py --dry-run --cluster-id 0x0040 --new-revision 4 | grep no-uniqueWill try to update: examples/lighting-app-data-mode-no-unique-id/lighting-common/lighting-app.zapFixes: #35334