Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing "is_commissioning=True" to step 1 in all DEM, EEVSE and EWATERHTR test scripts #35560

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/python_testing/TC_DEM_2_10.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ def pics_TC_DEM_2_10(self):
def steps_TC_DEM_2_10(self) -> list[TestStep]:
"""Execute the test steps."""
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads from the DUT the FeatureMap",
"Verify that the DUT response contains the FeatureMap attribute. Store the value as FeatureMap."),
TestStep("3", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_DEM_2_2.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ def pics_TC_DEM_2_2(self):
def steps_TC_DEM_2_2(self) -> list[TestStep]:
"""Execute the test steps."""
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads from the DUT the _FeatureMap_ attribute",
"Verify that the DUT response contains the _FeatureMap_ attribute. Verify PowerAdjustment is supported."),
TestStep("3", "Set up a subscription to all DeviceEnergyManagement cluster events"),
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_DEM_2_3.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ def pics_TC_DEM_2_3(self):

def steps_TC_DEM_2_3(self) -> list[TestStep]:
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads from the DUT the _FeatureMap_ attribute",
"Verify that the DUT response contains the _FeatureMap_ attribute. Verify StartTimeAdjustment feature is supported on the cluster. Verify PowerForecastReporting or StateForecastReporting feature is supported on the cluster."),
TestStep("3", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_DEM_2_4.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ def pics_TC_DEM_2_4(self):

def steps_TC_DEM_2_4(self) -> list[TestStep]:
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads from the DUT the _FeatureMap_ attribute",
"Verify that the DUT response contains the _FeatureMap_ attribute. Verify Pausable feature is supported on the cluster. Verify PowerForecastReporting or StateForecastReporting feature is supported on the cluster."),
TestStep("3", "Set up a subscription to all DeviceEnergyManagement cluster events"),
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_DEM_2_5.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ def pics_TC_DEM_2_5(self):
def steps_TC_DEM_2_5(self) -> list[TestStep]:
"""Execute the test steps."""
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads from the DUT the _FeatureMap_ attribute",
"Verify that the DUT response contains the _FeatureMap_ attribute. Verify ForecastAdjustment feature is supported on the cluster. Verify PowerForecastReporting feature is supported on the cluster. Verify StateForecastReporting feature is not supported on the cluster."),
TestStep("3", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_DEM_2_6.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ def pics_TC_DEM_2_6(self):
def steps_TC_DEM_2_6(self) -> list[TestStep]:
"""Execute the test steps."""
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads from the DUT the _FeatureMap_ attribute",
"Verify that the DUT response contains the _FeatureMap_ attribute. Verify ForecastAdjustment feature is supported on the cluster. Verify StateForecastReporting feature is supported on the cluster. Verify PowerForecastReporting feature is not supported on the cluster."),
TestStep("3", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_DEM_2_7.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ def pics_TC_DEM_2_7(self):
def steps_TC_DEM_2_7(self) -> list[TestStep]:
"""Execute the test steps."""
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads from the DUT the _FeatureMap_ attribute",
"Verify that the DUT response contains the _FeatureMap_ attribute. Verify ConstraintBasedAdjustment feature is supported on the cluster. Verify PowerForecastReporting feature is supported on the cluster. Verify StateForecastReporting feature is not supported on the cluster."),
TestStep("3", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_DEM_2_8.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ def pics_TC_DEM_2_8(self):
def steps_TC_DEM_2_8(self) -> list[TestStep]:
"""Execute the test steps."""
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads from the DUT the _FeatureMap_ attribute",
"Verify that the DUT response contains the _FeatureMap_ attribute. Verify ConstraintBasedAdjustment feature is supported on the cluster. Verify StateForecastReporting feature is supported on the cluster. Verify PowerForecastReporting feature is not supported on the cluster."),
TestStep("3", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_DEM_2_9.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ def pics_TC_DEM_2_9(self):
def steps_TC_DEM_2_9(self) -> list[TestStep]:
"""Execute the test steps."""
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads from the DUT the _FeatureMap_ attribute",
"Verify that the DUT response contains the _FeatureMap_ attribute. Verify one of PowerForecastReporting or StateForecastReporting is supported but not both."),
TestStep("3", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_EEVSE_2_2.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ def pics_TC_EEVSE_2_2(self):

def steps_TC_EEVSE_2_2(self) -> list[TestStep]:
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
"Value has to be 1 (True)"),
TestStep("3", "TH sends TestEventTrigger command to General Diagnostics Cluster on Endpoint 0 with EnableKey field set to PIXIT.EEVSE.TESTEVENT_TRIGGERKEY and EventTrigger field set to PIXIT.EEVSE.TESTEVENTTRIGGER for Basic Functionality Test Event",
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_EEVSE_2_3.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ def pics_TC_EEVSE_2_3(self):

def steps_TC_EEVSE_2_3(self) -> list[TestStep]:
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
"Value has to be 1 (True)"),
TestStep("3", "TH sends TestEventTrigger command to General Diagnostics Cluster on Endpoint 0 with EnableKey field set to PIXIT.EEVSE.TESTEVENT_TRIGGERKEY and EventTrigger field set to PIXIT.EEVSE.TESTEVENTTRIGGER for Basic Functionality Test Event",
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_EEVSE_2_4.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ def pics_TC_EEVSE_2_4(self):

def steps_TC_EEVSE_2_4(self) -> list[TestStep]:
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
"Value has to be 1 (True)"),
TestStep("3", "TH sends TestEventTrigger command to General Diagnostics Cluster on Endpoint 0 with EnableKey field set to PIXIT.EEVSE.TESTEVENT_TRIGGERKEY and EventTrigger field set to PIXIT.EEVSE.TESTEVENTTRIGGER for Basic Functionality Test Event",
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_EEVSE_2_5.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ def pics_TC_EEVSE_2_5(self):

def steps_TC_EEVSE_2_5(self) -> list[TestStep]:
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
"Value has to be 1 (True)"),
TestStep("3", "TH sends TestEventTrigger command to General Diagnostics Cluster on Endpoint 0 with EnableKey field set to PIXIT.EEVSE.TESTEVENT_TRIGGERKEY and EventTrigger field set to PIXIT.EEVSE.TESTEVENTTRIGGER for Basic Functionality Test Event",
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_EEVSE_2_6.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ def pics_TC_EEVSE_2_6(self):

def steps_TC_EEVSE_2_6(self) -> list[TestStep]:
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "TH reads from the DUT the FeatureMap",
"Verify that the DUT response contains the FeatureMap attribute. Store the value as FeatureMap."),
TestStep("3", "Set up a subscription to all EnergyEVSE cluster events"),
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_EWATERHTR_2_1.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ def pics_TC_EWATERHTR_2_1(self):

def steps_TC_EWATERHTR_2_1(self) -> list[TestStep]:
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)."),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test).",
is_commissioning=True),
TestStep("2", "TH reads from the DUT the FeatureMap attribute.",
"Verify that the DUT response contains the FeatureMap attribute. Store the value as FeatureMap."),
TestStep("3", "TH reads from the DUT the HeaterTypes attribute.",
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_EWATERHTR_2_2.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ def pics_TC_EWATERHTR_2_2(self):

def steps_TC_EWATERHTR_2_2(self) -> list[TestStep]:
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "Set up a subscription to all WaterHeaterManagement cluster events"),
TestStep("3", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
"Value has to be 1 (True)"),
Expand Down
3 changes: 2 additions & 1 deletion src/python_testing/TC_EWATERHTR_2_3.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ def pics_TC_EWATERHTR_2_3(self):

def steps_TC_EWATERHTR_2_3(self) -> list[TestStep]:
steps = [
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)"),
TestStep("1", "Commission DUT to TH (can be skipped if done in a preceding test)",
is_commissioning=True),
TestStep("2", "Set up a subscription to all WaterHeaterManagement cluster events"),
TestStep("3", "TH reads TestEventTriggersEnabled attribute from General Diagnostics Cluster",
"Value has to be 1 (True)"),
Expand Down
Loading