Move PWM color control callbacks from type stubs to the esp32 demo app #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
vivien-apple
force-pushed
the
Cluster_MovePWMCallbacks
branch
from
f5bed31 to
a46032d
Compare
vivien-apple
force-pushed
the
Cluster_MovePWMCallbacks
branch
from
a46032d to
1223fe4
Compare
rwalker-apple
approved these changes
Nov 2, 2020
mspang
approved these changes
Nov 3, 2020
jelderton
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I don't think it makes sense for the PWM color control callbacks to have been stubbed out as
#defineinsrc/app/util/types_stub.hsince it prevents users of color control to implement the callback themselves and it looks like an app specific callback.Summary of Changes
Fixes #2431
I'm marking it fixing #2431 because the other bits of #2431 has already been implemented by #2915 and I don't think there is anything left for the platform side in #2431