TC-OPSTATE-2.5: Force expire session on reboot #35712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the DUT has rebooted, the TH will need to establish the session again, which means expiring the current. In a real product, a fail on the case would trigger a retry, but it's not clear that we want that in the TH because it can paper over problems where the DUT is crashing. This is an intentional reboot, wihch is different. Probably not caught in CI / QA because the CI app doesn't actually reboot.
|
Review changes with SemanticDiff. Analyzed 1 of 1 files.
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
cecille
requested review from
rbultman and
beckerzito
and removed request for
beckerzito and
austina-csa
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran and
hawk248
pullapprove
bot
requested review from
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #35712: Size comparison from 6c0ba6e to 420d0fd Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Sep 22, 2024
rbultman
approved these changes
Sep 23, 2024
beckerzito
approved these changes
Sep 23, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
If the DUT has rebooted, the TH will need to establish the session again, which means expiring the current. In a real product, a fail on the case would trigger a retry, but it's not clear that we want that in the TH because it can paper over problems where the DUT is crashing. This is an intentional reboot, wihch is different. Probably not caught in CI / QA because the CI app doesn't actually reboot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the DUT has rebooted, the TH will need to establish the session again, which means expiring the current. In a real product, a fail on the case would trigger a retry, but it's not clear that we want that in the TH because it can paper over problems where the DUT is crashing. This is an intentional reboot, wihch is different.
Probably not caught in CI / QA because the CI app doesn't actually reboot.