-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove znet-bookkeeping.[h|c] files #3607
Merged
rwalker-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Cluster_RemoveZnetbookkeeping
Nov 4, 2020
Merged
Remove znet-bookkeeping.[h|c] files #3607
rwalker-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Cluster_RemoveZnetbookkeeping
Nov 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
November 3, 2020 13:35
Size increase report for "esp32-example-build" from 3a1312d
Full report output
|
Size increase report for "nrfconnect-example-build" from 3a1312d
Full report output
|
andy31415
approved these changes
Nov 3, 2020
mspang
approved these changes
Nov 3, 2020
vivien-apple
force-pushed
the
Cluster_RemoveZnetbookkeeping
branch
from
November 4, 2020 10:39
4ad9c44
to
bd7bec8
Compare
I pushed an update that removes the changes to the |
rwalker-apple
approved these changes
Nov 4, 2020
saurabhst
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to makes it easier to move forward on #3464, I'm trying to extract the parts that are not fully dependent on ZAP.
It should makes it easier to understand the scope of various changes from #3464
This PR is the part of #3464 that removes
znet-bookkeeping.h
andnet-bookkeeping.c
files from the gen/ folders.Summary of Changes
znet-bookeeping.h
andnet-bookkeeping.c
files from the various gen/ folders.src/app/util/af-main-common.c
andsrc/app/util/util.cpp
with the Callback prefix. Basically the znet-bookkeeping methods were just calling thoseemAfInit
->emberAfInit
.emAfInit
uses to callemberAfMainInitCallback
andemberAfInit
andemberAfMainInitCallback
was an empty stub.