Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove znet-bookkeeping.[h|c] files #3607

Conversation

vivien-apple
Copy link
Contributor

@vivien-apple vivien-apple commented Nov 3, 2020

Problem

In order to makes it easier to move forward on #3464, I'm trying to extract the parts that are not fully dependent on ZAP.
It should makes it easier to understand the scope of various changes from #3464

This PR is the part of #3464 that removes znet-bookkeeping.h and net-bookkeeping.c files from the gen/ folders.

Summary of Changes

  • Delete znet-bookeeping.h and net-bookkeeping.c files from the various gen/ folders.
  • Update the name of some methods in src/app/util/af-main-common.c and src/app/util/util.cpp with the Callback prefix. Basically the znet-bookkeeping methods were just calling those
  • emAfInit -> emberAfInit. emAfInit uses to call emberAfMainInitCallback and emberAfInit and emberAfMainInitCallback was an empty stub.

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Size increase report for "esp32-example-build" from 3a1312d

File Section File VM
chip-wifi-echo.elf .flash.text -180 -180
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.shstrtab,0,1
.debug_ranges,0,-88
.debug_aranges,0,-104
.symtab,0,-128
.flash.text,-180,-180
.strtab,0,-181
.debug_frame,0,-256
.debug_loc,0,-313
.debug_str,0,-424
.debug_abbrev,0,-576
.debug_line,0,-1520
.debug_info,0,-5083


@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Size increase report for "nrfconnect-example-build" from 3a1312d

File Section File VM
chip-lock.elf shell_root_cmds_sections -12 -12
chip-lock.elf text -68 -68
chip-lighting.elf shell_root_cmds_sections 4 4
chip-lighting.elf text -68 -68
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.shstrtab,0,1
shell_root_cmds_sections,-12,-12
text,-68,-68
.debug_ranges,0,-88
.debug_aranges,0,-104
.strtab,0,-161
.symtab,0,-208
.debug_frame,0,-244
.debug_str,0,-428
.debug_loc,0,-556
.debug_abbrev,0,-607
.debug_line,0,-1127
.debug_info,0,-5110

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
shell_root_cmds_sections,4,4
.shstrtab,0,-3
text,-68,-68
.debug_ranges,0,-88
.debug_aranges,0,-104
.strtab,0,-161
.symtab,0,-208
.debug_frame,0,-244
.debug_str,0,-342
.debug_loc,0,-558
.debug_abbrev,0,-607
.debug_line,0,-1147
.debug_info,0,-5110


@vivien-apple vivien-apple self-assigned this Nov 3, 2020
@vivien-apple vivien-apple force-pushed the Cluster_RemoveZnetbookkeeping branch from 4ad9c44 to bd7bec8 Compare November 4, 2020 10:39
@vivien-apple
Copy link
Contributor Author

I pushed an update that removes the changes to the nrf5 examples since #3605 has removed them.

@rwalker-apple
Copy link
Contributor

@rwalker-apple rwalker-apple merged commit ceecd84 into project-chip:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants