[nxp][examples][common][lock-app] Add DiagnosticLog and Update zap file #36120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrei-menzopol
commented
Oct 17, 2024
andrei-menzopol
commented
- Add DiagnosticLogs in lock-app ZclCallbacks.cpp
- Update zap file: enable door-lock attributes
|
Review changes with SemanticDiff. |
andrei-menzopol
force-pushed
the
lock-app-zap-diags
branch
from
b696ce1 to
9dbae32
Compare
|
PR #36120: Size comparison from 1a38286 to 9dbae32 Increases above 0.2%:
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Oct 17, 2024
andrei-menzopol
force-pushed
the
lock-app-zap-diags
branch
from
9dbae32 to
a5adfe2
Compare
|
PR #36120: Size comparison from 2574847 to a5adfe2 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
andrei-menzopol
force-pushed
the
lock-app-zap-diags
branch
2 times, most recently
from
ce60a61 to
16486ef
Compare
|
PR #36120: Size comparison from 0060e0e to 16486ef Increases above 0.2%:
Full report (79 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
doru91
approved these changes
Oct 18, 2024
andy31415
approved these changes
Oct 18, 2024
andrei-menzopol
force-pushed
the
lock-app-zap-diags
branch
from
16486ef to
ab0de82
Compare
|
PR #36120: Size comparison from d7abcbf to ab0de82 Full report (62 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
andrei-menzopol
force-pushed
the
lock-app-zap-diags
branch
from
ab0de82 to
0756266
Compare
Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
* Add DiagnosticLogs in lock-app ZclCallbacks.cpp * Update zap file: enable door-lock attributes Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Signed-off-by: Ethan Tan <ethan.tan@nxp.com>
andrei-menzopol
force-pushed
the
lock-app-zap-diags
branch
from
0756266 to
0f97f5f
Compare
|
PR #36120: Size comparison from d7abcbf to 0f97f5f Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Is the Build on Darwin (clang, simulated) test a known issue? I saw it in other PRs too. |
dinabenamar
pushed a commit
to NXP/matter
that referenced
this pull request
Oct 24, 2024
…d Update zap file (project-chip#36120) * [nxp][examples][common] Update zap files to support Aliro Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [nxp][examples][common][lock-app] Add DiagnosticLog and Update zap file * Add DiagnosticLogs in lock-app ZclCallbacks.cpp * Update zap file: enable door-lock attributes Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Signed-off-by: Ethan Tan <ethan.tan@nxp.com> --------- Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Signed-off-by: Ethan Tan <ethan.tan@nxp.com> (cherry picked from commit 6f0a70c)
marius-alex-tache
pushed a commit
to NXP/matter
that referenced
this pull request
Nov 14, 2024
…icLog and Update zap file (project-chip#36120)" This reverts commit 5ce370d. Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com>
GabrielCouturier
pushed a commit
to NXP/matter
that referenced
this pull request
Dec 11, 2024
…d Update zap file (project-chip#36120) * [nxp][examples][common] Update zap files to support Aliro Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [nxp][examples][common][lock-app] Add DiagnosticLog and Update zap file * Add DiagnosticLogs in lock-app ZclCallbacks.cpp * Update zap file: enable door-lock attributes Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Signed-off-by: Ethan Tan <ethan.tan@nxp.com> --------- Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Signed-off-by: Ethan Tan <ethan.tan@nxp.com> (cherry picked from commit 6f0a70c)
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…le (project-chip#36120) * [nxp][examples][common] Update zap files to support Aliro Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [nxp][examples][common][lock-app] Add DiagnosticLog and Update zap file * Add DiagnosticLogs in lock-app ZclCallbacks.cpp * Update zap file: enable door-lock attributes Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Signed-off-by: Ethan Tan <ethan.tan@nxp.com> --------- Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Signed-off-by: Ethan Tan <ethan.tan@nxp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.