-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Configure Light-Switch as a LIT ICD app #36221
[Silabs] Configure Light-Switch as a LIT ICD app #36221
Conversation
Review changes with SemanticDiff. |
PR #36221: Size comparison from 8933398 to 2a64b39 Full report (3 builds for cc32xx, stm32)
|
PR #36221: Size comparison from 8933398 to 229c866 Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
PR #36221: Size comparison from 8933398 to 0b9d3a5 Full report (3 builds for cc32xx, stm32)
|
PR #36221: Size comparison from 8933398 to 6387324 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested: do not use ifdef
or defined(....)
Also making lib depend on examples is something that needs fixing. |
5ce7f93
to
528926a
Compare
PR #36221: Size comparison from 197f698 to 528926a Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
77ba860
to
8891a9a
Compare
PR #36221: Size comparison from 59ffe33 to 8891a9a Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
8891a9a
to
cfeb1f1
Compare
PR #36221: Size comparison from 59ffe33 to cfeb1f1 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
PR #36221: Size comparison from 59ffe33 to 2d16cc9 Full report (3 builds for cc32xx, stm32)
|
PR #36221: Size comparison from 59ffe33 to b5cabb8 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
* Add ICD shell and make Light-switch LIT ICD * remove zcl changes * Move and rename shell files * Move ICD shells files * Start the shell structure refactor * Add lit-icd light-switch zap file * Add missing define guard * Add comment * Address review comments * remove empty change * fix gn file * Add missing include dir * zap generation * Update docker image version * restore zap templtes * Pull latest docker image * zap generation
Description
PR configures the Light-Swith as a LIT ICD with Dynamic Sit Lit Support
PR also pulls latest docker image which reducdes the size of the efr32 docker image.
Tests
Manual tests to validate everything works as expected