-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated spec_parsing.py to now use the data model directory from python package #36596
Updated spec_parsing.py to now use the data model directory from python package #36596
Conversation
Changed Files
|
PR #36596: Size comparison from 2439117 to 923470f Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36596: Size comparison from 2439117 to c57a3c1 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36596: Size comparison from 2439117 to 0d9eb87 Full report (14 builds for bl602, bl702, bl702l, nrfconnect, telink)
|
src/python_testing/matter_testing_infrastructure/chip/testing/spec_parsing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/spec_parsing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/spec_parsing.py
Outdated
Show resolved
Hide resolved
784f89e
to
d07b52f
Compare
PR #36596: Size comparison from 481270d to d07b52f Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followups include:
- do not return PosixPath, we can return Path if that is the API we want. We may want to just revert to
str
as it was before for now - remvoe indents for returns (shorten the code/indent level on early return instead of if/else)
src/python_testing/matter_testing_infrastructure/chip/testing/spec_parsing.py
Outdated
Show resolved
Hide resolved
dismiss: I was convinced we use importlib, yet we switched back to file for some reason.
Some various changes occurred in this PR since I reviewd it. Dismissing review.
… passed in path if applicable
… exception on invalid input type
Work for Issue #31317
PR 23 - Updated
spec_parsing.py
to dynamically reference the data model directory from the python packagechip_testing
ensuring consistent and flexible path handling