[Crypto] Replace OpenSSL-specific flag with public API to check SHA256 digest initialization #36608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
Alami-Amine
changed the title
|
PR #36608: Size comparison from 04e6a68 to c5ffbc1 Full report (25 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/OpenSSLSHA256V2
branch
from
c5ffbc1 to
758706d
Compare
This is a follow_up to project-chip#36386 based on a post-merge comment, - an OpenSSL-specific mInitialized flag was added to HASH_SHA256 to check if digest computation was initialised, which isn't used for other Crypto Backends - Fix: replace by a Public API `IsInitialized`, with its implementation for OpenSSL/BoringSSL
Alami-Amine
force-pushed
the
AA/OpenSSLSHA256V2
branch
from
758706d to
49e008f
Compare
|
PR #36608: Size comparison from 04e6a68 to 49e008f Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
changed the title
andy31415
approved these changes
Nov 22, 2024
yufengwangca
approved these changes
Nov 22, 2024
kiel-apple
approved these changes
Nov 22, 2024
| * | ||
| * @return True if the context is correctly initialized; otherwise, false. | ||
| */ | ||
| bool IsInitialized(); |
There was a problem hiding this comment.
Doesn't this need implementations for the non-OpenSSL/BoringSSL backends?
There was a problem hiding this comment.
And also: this looks like an API that API consumers should call before they do anything with the object.... but they very much don't do that, and if they tried it would not work with most of the backends. Why is this public API at all?
There was a problem hiding this comment.
+1. The method used here should be used more widely whenever the context is used at all. I would expect this API to be private since it's only used internally and should never be false. The idea is to avoid double-free or leaks, right?
There was a problem hiding this comment.
Yes this was a mistake, the IsInitialized is only to be used internally by Hash_SHA256_stream within the OpenSSL backend. So I will make IsInitialized protected.
@bzbarsky-apple Should I add a stub for IsInitialized in other backends or only add a comment in the *.h that it is only implemented in OpenSSL?
There was a problem hiding this comment.
If it's private/protected, it really does not matter; someone who tries to use it will know what they are doing and notice they need to implement it. So comment saying "implement this if your backend needs it" is fine.
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Nov 25, 2024
…hip#36608) This is a follow_up to project-chip#36386 based on a post-merge comment, - an OpenSSL-specific mInitialized flag was added to HASH_SHA256 to check if digest computation was initialised, which isn't used for other Crypto Backends - Fix: replace by a Public API `IsInitialized`, with its implementation for OpenSSL/BoringSSL
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…hip#36608) This is a follow_up to project-chip#36386 based on a post-merge comment, - an OpenSSL-specific mInitialized flag was added to HASH_SHA256 to check if digest computation was initialised, which isn't used for other Crypto Backends - Fix: replace by a Public API `IsInitialized`, with its implementation for OpenSSL/BoringSSL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow_up to #36386 based on a post-merge comment.
an OpenSSL-specific
mInitializedflag was added to HASH_SHA256 to check if digest computation was initialized, which isn't used for other Crypto Backends.It also added platform-specific
#ifdefsto the a platform-agnostic header.Fix: replace by a Public API
IsInitialized, with its implementation for OpenSSL/BoringSSL