TC-WASHERCTRL-2.1 Python migration #36720
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #36720: Size comparison from 38ad07d to 5f86eb2 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Dec 4, 2024
|
|
||
| return steps | ||
|
|
||
| @async_test_body |
There was a problem hiding this comment.
Please see comment here - would want to do the same thing in this PR, assuming the lined PR lands before this gets undrafted. #36703 (comment)
| # Write a valid SpinSpeedCurrent value | ||
| self.step(4) | ||
| requested_speed = random.randint(0, numSpinSpeeds - 1) | ||
| result = await self.default_controller.WriteAttribute(self.dut_node_id, |
There was a problem hiding this comment.
suggest using write_single_attribute function - it checks the return status for you and has some nice defaults for node and controller.
and below
There was a problem hiding this comment.
Thanks, I was aware of the read_single_attribute function but didn't knew about this one.
I changed both uses of the WriteAttribute function with the new one.
|
PR #36720: Size comparison from 38ad07d to f4450f0 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36720: Size comparison from 238e801 to 526b5bc Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a proposal for the Python implementation of the test Test_TC_WASHERCTRL_2_1.yaml
The intention is to verify that the DUT can respond to Laundry Washer Controls Cluster attribute read and write commands if the feature is supported.