[NXP][Zephyr] Migrate to nxp-zsdk v4.0.0 #36749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelnxp
force-pushed
the
upstream/nxp_zephyr_migration_4.0.0_platform
branch
from
2c6b6ba to
b631ab4
Compare
axelnxp
force-pushed
the
upstream/nxp_zephyr_migration_4.0.0_platform
branch
from
95fc697 to
ef633d7
Compare
|
PR #36749: Size comparison from 9e671ad to ef633d7 Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
chapongatien
approved these changes
Dec 6, 2024
andy31415
approved these changes
Dec 6, 2024
axelnxp
force-pushed
the
upstream/nxp_zephyr_migration_4.0.0_platform
branch
from
ef633d7 to
4af12a6
Compare
- Kconfigs/CMake updates for nxp-zsdk v4.0.0 (Zephyr 4.0 base) - Add ThreadMetrics support for Zephyr platforms - Add missing WiFi Diagnostic support for NXP Zephyr - Add Matter over WiFi support for frdm_rw612 - Update and fix memory overlays Restyled by clang-format Restyled by prettier-markdown
|
PR #36749: Size comparison from 84fb78f to 4af12a6 Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| { | ||
| size_t unusedStackSize; | ||
| ThreadMetrics ** threadMetricsListHead = (ThreadMetrics **) user_data; | ||
| ThreadMetrics * threadMetrics = (ThreadMetrics *) malloc(sizeof(ThreadMetrics)); |
There was a problem hiding this comment.
I think all allocations made by Matter should be done via Platform::New, which will btw. properly initialize the object. Also, you should validate if the allocation has succeeded.
| ThreadMetrics ** threadMetricsListHead = (ThreadMetrics **) user_data; | ||
| ThreadMetrics * threadMetrics = (ThreadMetrics *) malloc(sizeof(ThreadMetrics)); | ||
|
|
||
| Platform::CopyString(threadMetrics->NameBuf, k_thread_name_get((k_tid_t) thread)); |
There was a problem hiding this comment.
k_thread_name_get may return NULL if CONFIG_THREAD_NAME=n. This functionality should be configurable depending on thread name being enabled.
| @@ -33,8 +33,11 @@ namespace DeviceLayer { | |||
|
|
|||
| // Maximum length of vendor defined name or prefix of the software thread that is | |||
| // static for the duration of the thread. | |||
| #if defined(CONFIG_THREAD_MAX_NAME_LEN) | |||
| static constexpr size_t kMaxThreadNameLength = CONFIG_THREAD_MAX_NAME_LEN - 1; | |||
| #else | |||
| static constexpr size_t kMaxThreadNameLength = 8; | |||
There was a problem hiding this comment.
You shouldn't override this limit, as this comes from the spec.
| static void GetThreadInfo(const struct k_thread * thread, void * user_data) | ||
| { | ||
| size_t unusedStackSize; | ||
| ThreadMetrics ** threadMetricsListHead = (ThreadMetrics **) user_data; |
There was a problem hiding this comment.
nit: Could you use C++ cast operators like static_cast?
Comment on lines
+84
to
+91
| if (*threadMetricsListHead) | ||
| { | ||
| threadMetrics->Next = *threadMetricsListHead; | ||
| } | ||
| else | ||
| { | ||
| threadMetrics->Next = NULL; | ||
| } |
There was a problem hiding this comment.
This is equivalent to just:
Suggested change
| if (*threadMetricsListHead) | |
| { | |
| threadMetrics->Next = *threadMetricsListHead; | |
| } | |
| else | |
| { | |
| threadMetrics->Next = NULL; | |
| } | |
| threadMetrics->Next = *threadMetricsListHead; |
axelnxp
added a commit
to NXP/matter
that referenced
this pull request
Dec 9, 2024
Addressing review comments from project-chip#36749 Signed-off-by: Axel Le Bourhis <axel.lebourhis@nxp.com>
axelnxp
added a commit
to NXP/matter
that referenced
this pull request
Dec 9, 2024
Addressing review comments from project-chip#36749 Signed-off-by: Axel Le Bourhis <axel.lebourhis@nxp.com>
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Addressing review comments from #36749 Signed-off-by: Axel Le Bourhis <axel.lebourhis@nxp.com>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
- Kconfigs/CMake updates for nxp-zsdk v4.0.0 (Zephyr 4.0 base) - Add ThreadMetrics support for Zephyr platforms - Add missing WiFi Diagnostic support for NXP Zephyr - Add Matter over WiFi support for frdm_rw612 - Update and fix memory overlays Restyled by clang-format Restyled by prettier-markdown Co-authored-by: Yassine El Aissaoui <yassine.elaissaoui@nxp.com>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…-chip#36765) Addressing review comments from project-chip#36749 Signed-off-by: Axel Le Bourhis <axel.lebourhis@nxp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on a Docker image update PR: #36748