Ability to create out-of-tree MEI clusters #36818
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matter allows for MEI clusters. Currently, there is an example of such a cluster in the tree: sample-mei-server. If device vendors want to create their own MEI cluster, it currently needs to be included in tree, because app-common would not include information of the out-of-tree MEI cluster. This commits: * adds an example for an external MEI cluster * adds an mei-template.json that creates app-common out-of-tree * adds build system modifications so that app-common which includes the external MEI cluster is being used when EXTERNAL_APP_COMMON is given to chip_configure_data_model().
|
PR #36818: Size comparison from 75ab4c9 to 3158e54 Full report (3 builds for cc32xx, stm32)
|
There was a problem hiding this comment.
"mei" just means "identifier", in Matter... This is trying to show an example of a vendor-prefixed cluster, right? Should probably be named accordingly.
There was a problem hiding this comment.
This is named similar to https://github.com/project-chip/connectedhomeip/blob/master/src/app/clusters/sample-mei-server/sample-mei-server.cpp which is currently in the tree.
There was a problem hiding this comment.
Understood, and that one is not named well and should probably be renamed....
bauerschwan
reviewed
Dec 17, 2024
There was a problem hiding this comment.
why not just remove this instead of commenting it out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matter allows for MEI clusters. Currently, there is an example of such a cluster in the tree: sample-mei-server. If device vendors want to create their own MEI cluster, it currently needs to be included in tree, because app-common would not include information of the out-of-tree MEI cluster.
This commits: