[Fabrix-Sync] Fix ICD device commissioning process #36821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36821: Size comparison from 6706f33 to 5a719ea Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Dec 12, 2024
andy31415
requested changes
Dec 13, 2024
There was a problem hiding this comment.
@arkq at a recent SWTT standup we decided to try once again for stricter "require tests".
Could you please update the "testing" section to describe how this was tested in detail including a strong justification of why this is impossible to test in an automated fashion. We are making the "tested manually" bar intentionally annoying to avoid having all PRs marked as "tested manually" because it is easier.
This is something that currently exists in CI, so I wonder why the tests do not cover this. I would have expected some test changes to be possible.
@andy31415 The goal of all these fixes is to run fabric-sync python tests on CI. The same tests which check
I'm trying to adhere to that rule whenever possible :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's not possible to pair ICD device with
app pair-device <node> <setupQRCode> --enable-icd-registrationbecause theResetForNextCommandis called in the middle of the commissioning which disrupts internal state.Changes
PairingManager::OnCommissioningComplete, so it can be passed toStartDeviceSynchronizationTesting
Tested locally that it's possible to pair ICD device.