-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SPAKE2p pairing code to match spec #4166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bhaskar-apple,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
December 10, 2020 19:38
mspang
approved these changes
Dec 10, 2020
rebased |
balducci-apple
approved these changes
Dec 10, 2020
- update message handshake to include PBKDF param exchange - update msg types and error codes - add error handling via error message handshake
rebased |
@saurabhst, @jelderton, @BroderickCarlin , do you have any comments? |
Size increase report for "nrfconnect-example-build" from 27d3ea8
Full report output
|
Size increase report for "esp32-example-build" from 27d3ea8
Full report output
|
saurabhst
approved these changes
Dec 11, 2020
andy31415
approved these changes
Dec 11, 2020
bzbarsky-apple
requested changes
Dec 11, 2020
bzbarsky-apple
approved these changes
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current pairing code is based on the earlier version of the spec, and the spec has evolved since then. The code needs updates to match the latest specifications.
Summary of Changes
Fixes #4135