-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate device controller to messaging layer API #4171
Conversation
bc79875
to
e46b6d3
Compare
@kghost This is still marked draft. Is it ready for review? |
Not yet, we need to agree on Channel API first, this is also an illustration of use case of Channel API. |
OK. I was asking because there was an explicit review request, and I was trying to understand the state of things here. Please let me know if/when you want review here, or if you only want review for part of it which part. |
This will not be a small change to device controller, we'd better discuss it first. We can hang on slack later. I want to decouple controller from transport layer, and use messaging layer APIs to replace transport layer APIs. Messaging layer is much more friendly for applications. This code is PoC of that direction, it is move forward to it but lots of details are missing. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This stale pull request has been automatically closed. Thank you for your contributions. |
Problem
Migrate to messaging layer #4170
Summary of Changes
Change device controller to messaging layer API instead of secure session manager.
Please ignore first commit, focus on the second commit. This PR depends on Channel API #4019, first commit is that PR
There are several issues need to be resolved:
ChannelBuilder
; The blue boxes is the device commissioner, and IMHO, it should be moved into transport layer, because they are not device dependent.