Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle API SecureManager::SendMessage, use SecureSessoinHandle instead NodeId #4326

Closed
wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Jan 12, 2021

A duplicate of #3728 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@restyled-io restyled-io bot added the restyled label Jan 12, 2021
@restyled-io restyled-io bot closed this Jan 12, 2021
@restyled-io restyled-io bot deleted the restyled/pull-3728 branch January 12, 2021 04:18
@github-actions
Copy link

Size increase report for "esp32-example-build" from 4bb0e53

File Section File VM
chip-all-clusters-app.elf .flash.text 192 192
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,1668
.debug_line,0,801
.debug_loc,0,508
.debug_str,0,333
.debug_ranges,0,312
.flash.text,192,192
.xt.prop._ZN4chip24SecureSessionMgrDelegate19OnConnectionExpiredENS_19SecureSessionHandleEPNS_16SecureSessionMgrE,0,76
.xt.prop._ZN4chip9Transport15PeerConnectionsILj16ELNS_4Time6SourceE0EE23FindPeerConnectionStateENS_8OptionalIyEEtPNS0_19PeerConnectionStateE,0,52
.debug_abbrev,0,24
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,2
.strtab,0,-4
.symtab,0,-32
.xt.lit._ZNK4chip8OptionalINS_9Transport11PeerAddressEE5ValueEv,0,-40
.xt.prop._ZN4chip24SecureSessionMgrDelegate19OnConnectionExpiredEPKNS_9Transport19PeerConnectionStateEPNS_16SecureSessionMgrE,0,-76
.xt.prop._ZN4chip9Transport15PeerConnectionsILj16ELNS_4Time6SourceE0EE23FindPeerConnectionStateEyPNS0_19PeerConnectionStateE,0,-176
.shstrtab,0,-260


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 4bb0e53

File Section File VM
chip-lighting.elf text 260 260
chip-lighting.elf shell_root_cmds_sections 12 12
chip-lock.elf text 260 260
chip-lock.elf shell_root_cmds_sections -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,1435
.debug_line,0,588
.debug_str,0,333
.debug_ranges,0,272
text,260,260
.debug_frame,0,92
.debug_abbrev,0,57
shell_root_cmds_sections,12,12
.strtab,0,-4
.debug_loc,0,-153

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,1435
.debug_line,0,588
.debug_str,0,333
.debug_ranges,0,272
text,260,260
.debug_frame,0,92
.debug_abbrev,0,57
.strtab,0,-4
shell_root_cmds_sections,-4,-4
.debug_loc,0,-145

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants