Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Move chip::Logging::LogV to platform-specific implementation #4842

Closed
wants to merge 39 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Feb 12, 2021

A duplicate of #4741 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • gn

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

- Removed mutually exclusive `#defines`
- Removed STDIO_WITH_TIMESTAMPS since it is never set/used
…one, add dependencies for some sample applications
…ll look into moving platform-specific logging back one by one
@restyled-io restyled-io bot added the restyled label Feb 12, 2021
@todo
Copy link

todo bot commented Feb 12, 2021

figure out a way to auto-define dependency on stdio logging.

# TODO: figure out a way to auto-define dependency on stdio logging.
# This dep is required since libSupportLayer now does not include
# a default implementation.
#
# Tests such as TestInetEndPoint need to exercise the system event
# loop however they do not seem to include a logging binding so this
# is forcefully added here.
public_deps += [ "${chip_root}/src/platform/logging:stdio" ]
}
if (chip_link_tests) {


This comment was generated by todo based on a TODO comment in a3f5601 in #4842. cc @project-chip.

@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from ea7d70a

File Section File VM
chip-shell.elf rodata 8 8
chip-shell.elf text -4 -4
chip-shell.elf log_const_sections -12 -12
chip-lighting.elf rodata 8 8
chip-lighting.elf shell_root_cmds_sections 4 4
chip-lighting.elf text -4 -4
chip-lock.elf rodata 8 8
chip-lock.elf shell_root_cmds_sections 4 4
chip-lock.elf text -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_line,0,799
.symtab,0,16
.strtab,0,13
rodata,8,8
.shstrtab,0,3
text,-4,-4
.debug_aranges,0,-8
log_const_sections,-12,-12
.debug_frame,0,-24
.debug_ranges,0,-72
.debug_str,0,-88
.debug_loc,0,-272
.debug_abbrev,0,-2259
.debug_info,0,-15788

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_line,0,3751
.symtab,0,16
.strtab,0,13
rodata,8,8
shell_root_cmds_sections,4,4
.shstrtab,0,-1
text,-4,-4
.debug_aranges,0,-8
.debug_frame,0,-24
.debug_ranges,0,-72
.debug_str,0,-88
.debug_loc,0,-280
.debug_abbrev,0,-3079
.debug_info,0,-16072

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_line,0,3753
.symtab,0,16
.strtab,0,13
rodata,8,8
shell_root_cmds_sections,4,4
.shstrtab,0,-1
text,-4,-4
.debug_aranges,0,-8
.debug_frame,0,-24
.debug_ranges,0,-72
.debug_str,0,-88
.debug_loc,0,-280
.debug_abbrev,0,-3080
.debug_info,0,-16073


@github-actions
Copy link

Size increase report for "esp32-example-build" from ea7d70a

File Section File VM
chip-pigweed-app.elf .flash.rodata 4 4
chip-pigweed-app.elf .flash.text -28 -28
chip-all-clusters-app.elf .flash.text -28 -28
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize
.strtab,0,16
.flash.rodata,4,4
.xt.prop._ZSt9__find_ifIPKSt4byteN9__gnu_cxx5__ops10_Iter_predIPFbS0_EEEET_S9_S9_T0_St26random_access_iterator_tag,0,1
[Unmapped],0,-4
.debug_aranges,0,-8
.debug_ranges,0,-8
.debug_frame,0,-24
.flash.text,-28,-28
.debug_loc,0,-97
.debug_line,0,-2087
.debug_abbrev,0,-2161
.debug_str,0,-5590
.debug_info,0,-31242

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_line,0,10714
.strtab,0,16
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,-2
.debug_aranges,0,-8
.debug_ranges,0,-8
.debug_frame,0,-24
.flash.text,-28,-28
.debug_str,0,-72
.debug_loc,0,-107
.debug_abbrev,0,-3902
.debug_info,0,-32955


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants