New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import generic implementation of connection manager #52

Merged

woody-apple merged 7 commits into project-chip:master from pan-apple:platform-layer

Mar 13, 2020

Contributor

pan-apple commented Mar 13, 2020

No description provided.

pan-apple requested review from anush-apple, BroderickCarlin, chrisdecenzo, gerickson, hawk248, robszewczyk, tpmanley and woody-apple as code owners

March 13, 2020 18:13

woody-apple requested changes

View reviewed changes

src/platform/include/CHIPDeviceLayer.h Outdated

               #endif // CHIP_DEVICE_CONFIG_ENABLE_THREAD
               namespace chip {
               namespace DeviceLayer {
               struct chipDeviceEvent;
+              /*

Contributor

woody-apple Mar 13, 2020

Let's delete rather than comment?

Contributor

gerickson Mar 13, 2020

+1

src/platform/include/ConnectivityManagerImpl.h Outdated

+              class ConnectivityManagerImpl final
+                  : public ConnectivityManager,
+                    public Internal::GenericConnectivityManagerImpl<ConnectivityManagerImpl>,
+              #if CHIP_DEVICE_CONFIG_ENABLE_WOBLE

Contributor

woody-apple Mar 13, 2020

WOBLE means Weave Over BLE. Can we name this DOBLE? (Data over BLE?)... or something else - given we're removing input technology specific references. Thanks!

Contributor

gerickson Mar 13, 2020

I'd recommend CHIPOBLE for the time being for consistency's sake.

Contributor

woody-apple Mar 13, 2020

I'm fine with that... 🤣

Contributor

gerickson Mar 13, 2020

Further rationale: xoBLE connections are initiated based on the specific contents of a BLE advertisement. Thread over BLE connections are in response to a Thread-specific BLE advertisement. WoBLE in response to a Weave-specific BLE advertisement. Likewise, CHIP connections would be in response to a CHIP-specific BLE advertisement.

src/platform/include/internal/BLEManager.h Outdated

+               * Provides control over WoBLE services and connectivity for a chip device.
+               *
+               * BLEManager defines the abstract interface of a singleton object that provides
+               * control over WoBLE services and connectivity for a chip device.  BLEManager

Contributor

woody-apple Mar 13, 2020

WoBLE

Contributor

gerickson Mar 13, 2020

I'd recommend CHIPOBLE for the time being for consistency's sake.

src/platform/include/internal/GenericConnectivityManagerImpl_BLE.h Outdated


		// ===== Methods that implement the ConnectivityManager abstract interface.

		ConnectivityManager::WoBLEServiceMode _GetWoBLEServiceMode(void);

Contributor

woody-apple Mar 13, 2020

WoBLE

Contributor

gerickson Mar 13, 2020

I'd recommend CHIPOBLE for the time being for consistency's sake.

src/platform/include/internal/GenericConnectivityManagerImpl_BLE.ipp Outdated

+              {
+                  switch (mode)
+                  {
+                  case ConnectivityManager::kWoBLEServiceMode_NotSupported:

Contributor

woody-apple Mar 13, 2020

WoBLE

Contributor

gerickson Mar 13, 2020

I'd recommend CHIPOBLE for the time being for consistency's sake.

src/platform/include/internal/GenericConnectivityManagerImpl_NoBLE.h Outdated

+              };
+              template<class ImplClass>
+              inline ConnectivityManager::WoBLEServiceMode GenericConnectivityManagerImpl_NoBLE<ImplClass>::_GetWoBLEServiceMode(void)

Contributor

woody-apple Mar 13, 2020

WoBLE

Contributor

gerickson Mar 13, 2020

I'd recommend CHIPOBLE for the time being for consistency's sake.

gerickson reviewed

View reviewed changes

src/platform/include/CHIPDeviceLayer.h

-              #include <platform/CHIPDeviceError.h>
-              #include <platform/GeneralUtils.h>
+              // #include <core/CHIPGlobals.h>
+              #include <CHIPDeviceConfig.h>

Contributor

gerickson Mar 13, 2020

I'd recommend maintaining a multi-level include approach or we'll need to come up with a naming scheme that avoids header name collisions.

Contributor Author

pan-apple commented Mar 13, 2020

@woody-apple , @gerickson the latest commit should address the comments

gerickson approved these changes

View reviewed changes

hawk248 approved these changes

View reviewed changes

hawk248 left a comment

👍

jelderton approved these changes

View reviewed changes

pan-apple added 7 commits

March 13, 2020 13:09


          Fix typo RESPOSNE => RESPONSE

2161b44


          Fix included header paths

2de495f


          Import connection manager impl and its generic dependencies

41aa071


          Change namespace of connection manager to CHIP

033c41c


          Update namespace for BLE manager

e256392


          Fix camel casing in BLEManager

484ffbc


          Replace WoBle with CHIPoBle

4cf23e9

pan-apple force-pushed the platform-layer branch from 103d894 to 4cf23e9 Compare

March 13, 2020 20:16

Contributor Author

pan-apple commented Mar 13, 2020

Rebased and resolved merge conflicts

woody-apple approved these changes

View reviewed changes

woody-apple merged commit caebe36 into project-chip:master

pan-apple deleted the platform-layer branch

March 13, 2020 20:18

pan-apple mentioned this pull request

Change to multi level include directives for platform headers #56

Merged

fkjagodzinski pushed a commit to fkjagodzinski/connectedhomeip that referenced this pull request


          Merge pull request project-chip#52 from fkjagodzinski/ble-manager

063a697

Add BLEManagerImpl for mbed-os

wilbur-se mentioned this pull request

[TE9][TC-DM-2.1] some test steps need returned status UNSUPPORTED_WRITE(0x88) but (UNSUPPORTED_ATTRIBUTE)(0x86) #18248

Closed

jmartinez-silabs referenced this pull request in SiliconLabs/matter


          Pull request #52: Added example of credentials injection.

6f8c8e1

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

lpbeliveau-silabs pushed a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request


          Pull request project-chip#52: Added example of credentials injection.

ea603d1

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

mkardous-silabs referenced this pull request in SiliconLabs/watt-sandbox


          Pull request #52: Added example of credentials injection.

9640bf0

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

jmartinez-silabs referenced this pull request in SiliconLabs/matter


          Pull request #52: Added example of credentials injection.

96c9307

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request


          Pull request project-chip#52: Added example of credentials injection.

6be3e93

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip


          Pull request #52: Added example of credentials injection.

46176cf

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip


          Pull request #52: Added example of credentials injection.

611898d

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

jculbert pushed a commit to jculbert/connectedhomeip that referenced this pull request


          Pull request project-chip#52: Added example of credentials injection.

e88e672

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

Thirsrin pushed a commit to Thirsrin/connectedhomeip that referenced this pull request


          Pull request project-chip#52: Added example of credentials injection.

de45f04

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request


          Pull request project-chip#52: Added example of credentials injection.

9bc1f3c

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

M201370367 mentioned this pull request

[BUG] crash: JNI NewByteArray called with pending exception java.lang.AbstractMethodError #29997

Open

shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request


          Pull request project-chip#52: Added example of credentials injection.

a3edfd9

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

suveshpratapa pushed a commit to suveshpratapa/connectedhomeip that referenced this pull request


          Pull request project-chip#52: Added example of credentials injection.

c2cda35

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

mykrupp pushed a commit to mykrupp/connectedhomeip that referenced this pull request


          Pull request project-chip#52: Added example of credentials injection.

96fd76c

Merge in WMN_TOOLS/matter from credentials_example to silabs

Squashed commit of the following:

commit c90ed96cefc627f8e85584b587d06cf9f0e3210c
Author: Rehan Rasool <rehan.rasool@silabs.com>
Date:   Fri Sep 2 14:07:04 2022 -0400

    Fix numbers sequence

commit de19989a9006d55fb102154dfc51ba6ac8ea24e5
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:53:22 2022 -0400

    Fix formatting

commit 574f7a95c4d2c2c03a4a944f86b79a69763aa396
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:51:09 2022 -0400

    Address review comments

commit b91a03a3da9a870736f96be9cc8af11ddb58eeef
Author: Sergei Lissianoi <selissia@silabs.com>
Date:   Fri Sep 2 13:15:49 2022 -0400

    Fix typo and update README

commit 8cfe380f59ce4c0dff769ae4e7ff614bcf64113a
Author: Ezra Hale <ezra.hale@silabs.com>
Date:   Wed Aug 31 10:09:56 2022 -0400

    added rest of information from confluence page to flush out credentials example README.md

commit df1d5c8129d3999a83ba64edf4341757a9ef09dc
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Aug 26 13:42:32 2022 -0400

    Added example of credentials' injection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jelderton jelderton approved these changes

woody-apple woody-apple approved these changes

hawk248 hawk248 approved these changes

gerickson gerickson approved these changes

anush-apple Awaiting requested review from anush-apple

BroderickCarlin Awaiting requested review from BroderickCarlin

chrisdecenzo Awaiting requested review from chrisdecenzo

robszewczyk Awaiting requested review from robszewczyk

tpmanley Awaiting requested review from tpmanley

Labels

None yet