Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CRMP for mesages from the server side of the data model. #6508

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

This part seems to pass CI fine. It's messages from the client that
are being a problem.

Problem

CRMP is not enabled for messages that the cluster code sends in response to commands.

Summary of Changes

Enable CRMP there.

@boring-cyborg boring-cyborg bot added the app label May 5, 2021
This part seems to pass CI fine.  It's messages from the client that
are being a problem.
@github-actions
Copy link

github-actions bot commented May 5, 2021

Size increase report for "nrfconnect-example-build" from 0fe16aa

File Section File VM
chip-lighting.elf device_handles -4 -4
chip-lighting.elf text -12 -12
chip-lock.elf device_handles -4 -4
chip-lock.elf text -12 -12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
device_handles,-4,-4
text,-12,-12
.debug_line,0,-16
.debug_ranges,0,-16
.debug_info,0,-48
.debug_loc,0,-48

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
device_handles,-4,-4
text,-12,-12
.debug_line,0,-16
.debug_ranges,0,-16
.debug_info,0,-48
.debug_loc,0,-48


@github-actions
Copy link

github-actions bot commented May 5, 2021

Size increase report for "esp32-example-build" from 0fe16aa

File Section File VM
chip-all-clusters-app.elf .flash.text -12 -12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.text,-12,-12
.debug_line,0,-44
.debug_loc,0,-48
.debug_info,0,-52


@andy31415 andy31415 merged commit 92ac8bc into project-chip:master May 6, 2021
@andy31415
Copy link
Contributor

Force-merged ignoring the integration test lockout.

@bzbarsky-apple bzbarsky-apple deleted the enable-crmp-on-server branch May 6, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants