Remove the storage delegate's queue from the storage bridge #6519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
vivien-apple
woody-apple
approved these changes
May 6, 2021
msandstedt
approved these changes
May 6, 2021
andy31415
approved these changes
May 6, 2021
woody-apple
approved these changes
May 6, 2021
erjiaqing
added a commit
to erjiaqing/connectedhomeip
that referenced
this pull request
May 7, 2021
andy31415
pushed a commit
that referenced
this pull request
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The storage delegate bridge is using the delegate queue only for writes.
Since the Storage APIs are all sync right now, there's no use of this queue.
In the future if we reintroduce Async APIs, we it's perfectly acceptable to require the Delegate to make their implementation thread safe rather than promising to call them back on a queue they supplied.
Summary of Changes
Removed the delegate queue passed into the storage delegate bridge.
Now the delegate bridge directly calls into the delegate's APIs and it's upto the delegate to ensure thread safety.