-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Label to FabricDescriptorStruct and hook up logic with UpdateFabr… #7361
Conversation
…icLabel (project-chip#6670) * Adds Label to FabricDescriptor struct + regens files Adds fabric label to AdminPairingInfo with persistence support Hooks up UpdateFabricLabel to SetFabricLabel and writes the fabric label into the attribute list upon changes. How was this tested? (at least one bullet point required) - Added UI in chiptool ios to test this and tested that the label can be modifiled, nulled out and persists after m5stack reboots * regen files * Restyled by whitespace * Restyled by clang-format * switching to -std=gnu++14 * Restyled by clang-format * switch from 14 to 17 Co-authored-by: Restyled.io <commits@restyled.io>
Add Label once CHAR_STRING or OCTET_STRING worksconnectedhomeip/src/app/zap-templates/zcl/custom-types.xml Lines 61 to 64 in dbdc8bf
This comment was generated by todo based on a
|
VerifyOrExit(err == CHIP_NO_ERROR, status = EMBER_ZCL_STATUS_FAILURE); | ||
|
||
exit: | ||
writeAdminsIntoFabricsListAttribute(); | ||
emberAfSendImmediateDefaultResponse(status); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this supposed to send back an OpCertResponse
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, but that's not implemented yet, afaict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boris is correct, I am working on getting this up to spec.
Size increase report for "nrfconnect-example-build" from 575f99d
Full report output
|
Size increase report for "esp32-example-build" from 575f99d
Full report output
|
Size increase report for "gn_qpg6100-example-build" from 575f99d
Full report output
|
project-chip#7361) * Add Label to FabricDescriptorStruct and hook up logic with UpdateFabricLabel (project-chip#6670) * Adds Label to FabricDescriptor struct + regens files Adds fabric label to AdminPairingInfo with persistence support Hooks up UpdateFabricLabel to SetFabricLabel and writes the fabric label into the attribute list upon changes. How was this tested? (at least one bullet point required) - Added UI in chiptool ios to test this and tested that the label can be modifiled, nulled out and persists after m5stack reboots * regen files * Restyled by whitespace * Restyled by clang-format * switching to -std=gnu++14 * Restyled by clang-format * switch from 14 to 17 Co-authored-by: Restyled.io <commits@restyled.io> * Update bridge generated code Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
This was reverted yesterday due to CI failing. CI is being fixed by #7360
Once that is merged, we can then integrate this back in.
Adds fabric label to AdminPairingInfo with persistence support
Hooks up UpdateFabricLabel to SetFabricLabel and writes the fabric label into the attribute list upon changes.
How was this tested? (at least one bullet point required)
regen files
Restyled by whitespace
Restyled by clang-format
switching to -std=gnu++14
Restyled by clang-format
switch from 14 to 17
Co-authored-by: Restyled.io commits@restyled.io
Problem
What is being fixed? Examples:
Change overview
What's in this PR
Testing
How was this tested? (at least one bullet point required)