Fix System vs Inet and BLE shutdown order #7429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Inet and BLE contain pointers to the System::Layer, but in some implementations System::Layer is shut down first, leaving those pointers invalid. (There appear to be no current uses of those invalid pointers in the tree.) #### Change overview Shut down system layer after the others in: - `DeviceController::Shutdown()` - `GenericPlatformManagerImpl::_Shutdown()` - `JNI_OnUnload()` #### Testing - Some existing unit tests use the correct order (System last), so it's known to work. - Manually tested with platforms using `GenericPlatformManagerImpl::_Shutdown()` (Linux paired with ESP32).
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
mspang
approved these changes
Jun 7, 2021
msandstedt
approved these changes
Jun 7, 2021
bzbarsky-apple
approved these changes
Jun 8, 2021
andy31415
approved these changes
Jun 8, 2021
I will add brief comments for these in the event-loop PR that sparked this change. |
andy31415
pushed a commit
that referenced
this pull request
Jun 9, 2021
#### Problem Inet and BLE contain pointers to the System::Layer, but in some implementations System::Layer is shut down first, leaving those pointers invalid. (There appear to be no current uses of those invalid pointers in the tree.) #### Change overview Shut down system layer after the others in: - `DeviceController::Shutdown()` - `GenericPlatformManagerImpl::_Shutdown()` - `JNI_OnUnload()` #### Testing - Some existing unit tests use the correct order (System last), so it's known to work. - Manually tested with platforms using `GenericPlatformManagerImpl::_Shutdown()` (Linux paired with ESP32).
doublemis1
pushed a commit
to doublemis1/connectedhomeip
that referenced
this pull request
Jul 7, 2021
#### Problem Inet and BLE contain pointers to the System::Layer, but in some implementations System::Layer is shut down first, leaving those pointers invalid. (There appear to be no current uses of those invalid pointers in the tree.) #### Change overview Shut down system layer after the others in: - `DeviceController::Shutdown()` - `GenericPlatformManagerImpl::_Shutdown()` - `JNI_OnUnload()` #### Testing - Some existing unit tests use the correct order (System last), so it's known to work. - Manually tested with platforms using `GenericPlatformManagerImpl::_Shutdown()` (Linux paired with ESP32).
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
#### Problem Inet and BLE contain pointers to the System::Layer, but in some implementations System::Layer is shut down first, leaving those pointers invalid. (There appear to be no current uses of those invalid pointers in the tree.) #### Change overview Shut down system layer after the others in: - `DeviceController::Shutdown()` - `GenericPlatformManagerImpl::_Shutdown()` - `JNI_OnUnload()` #### Testing - Some existing unit tests use the correct order (System last), so it's known to work. - Manually tested with platforms using `GenericPlatformManagerImpl::_Shutdown()` (Linux paired with ESP32).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Inet and BLE contain pointers to the System::Layer, but in some
implementations System::Layer is shut down first, leaving those
pointers invalid. (There appear to be no current uses of those
invalid pointers in the tree.)
Change overview
Shut down system layer after the others in:
DeviceController::Shutdown()GenericPlatformManagerImpl::_Shutdown()JNI_OnUnload()Testing
so it's known to work.
GenericPlatformManagerImpl::_Shutdown()(Linux paired with ESP32).