Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send msg3 if key confirm fails in PASE #7502

Conversation

pan-apple
Copy link
Contributor

Problem

PASE Session state machine is sending Msg3 even if KeyConfirm fails. It later sends the error message as well.
It should send Msg3 only after all the checks are complete.

Change overview

Move the code to send Msg3 after KeyConfirm.

Testing

Added a unit test to trigger condition where KeyConfirm would fail.
Manually tested the flow using Python controller, chip-tool controller, and iOS CHIPTool apps.

@pan-apple pan-apple force-pushed the fix-pase-error-condition-handling branch from b8d7e00 to 472588c Compare June 10, 2021 00:32
@pan-apple
Copy link
Contributor Author

rebased

@github-actions
Copy link

Size increase report for "esp32-example-build" from 1f1b715

File Section File VM
chip-all-clusters-app.elf .flash.text -32 -32
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_loc,0,134
.debug_info,0,18
.debug_line,0,14
.debug_str,0,-2
.flash.text,-32,-32

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize


@bzbarsky-apple bzbarsky-apple merged commit e0c7b6d into project-chip:master Jun 10, 2021
@pan-apple pan-apple deleted the fix-pase-error-condition-handling branch June 10, 2021 13:23
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants