Do not send msg3 if key confirm fails in PASE #7502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PASE Session state machine is sending
Msg3
even ifKeyConfirm
fails. It later sends the error message as well.It should send
Msg3
only after all the checks are complete.Change overview
Move the code to send
Msg3
afterKeyConfirm
.Testing
Added a unit test to trigger condition where
KeyConfirm
would fail.Manually tested the flow using Python controller, chip-tool controller, and iOS CHIPTool apps.