-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print pin code and long discriminator on QR screen #7514
Conversation
This is very helpful info, and it's already part of the QR code string anyway.
uint16_t discriminator; | ||
if (ConfigurationMgr().GetSetupDiscriminator(discriminator) == CHIP_NO_ERROR) | ||
{ | ||
ESP_LOGI(TAG, "Setup discriminator: %u (0x%x)", discriminator, discriminator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cecille This is helpful. Just a suggestion: Can you add the print statements in the function createSetupPayload
where the discriminator and the setup pin code are already populated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure - I'll add them there too. I want them on the QR code screen as well so I don't have to go back in the logs when I'm looking for them.
Means other devices can see it too.
Size increase report for "esp32-example-build" from e0c7b6d
Full report output
|
* Print pin code and long discriminator on QR screen This is very helpful info, and it's already part of the QR code string anyway. * Also add prints at QR code generation. Means other devices can see it too.
This is very helpful info, and it's already part of the QR code
string anyway.
Problem
Setup PIN code is hard to find. It's part of the QR code, but that's hard to parse as a human.
Change overview
M5 all cluster app only - Prints setup pin code and long discriminator when you go to the QR code screen.
Testing
Manual - went to QR code screen, saw prints.