ESP32: Add RPC service to lock-app. #7584

sweetymhaiske · 2021-06-14T01:34:51Z

Problem

Lighting example is not present for esp32.
Lighting example in CHIP is equivalent to lock-app example.
Lighting example has RPC communication.
Hence in order to avoid redundancy by replicating the example, just add RPC communication feature to lock-app esp32.

Change overview

Added the necessary changes for pigweed in lock-app esp32.

Testing

Using a pigweed RPC console, perform actions on device_service, locking_service, and button_service.

todo · 2021-06-14T01:34:53Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 102 to 112 in 9a69f92

    
             // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
             return pw::Status::Unimplemented(); 
        
           } 
        
           pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty &request, 
        
                                    chip_rpc_DeviceInfo &response) { 
        
             response.vendor_id = 1234; 
        
             response.product_id = 5678; 
        
             response.software_version = 0; 
        
             return pw::OkStatus(); 
        
           }

This comment was generated by todo based on a `TODO` comment in `9a69f92` in #7584. cc @sweetymhaiske.

todo · 2021-06-14T02:02:34Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 102 to 112 in ca3f3c6

    
             // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
             return pw::Status::Unimplemented(); 
        
           } 
        
           pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty &request, 
        
                                    chip_rpc_DeviceInfo &response) { 
        
             response.vendor_id = 1234; 
        
             response.product_id = 5678; 
        
             response.software_version = 0; 
        
             return pw::OkStatus(); 
        
           }

This comment was generated by todo based on a `TODO` comment in `ca3f3c6` in #7584. cc @sweetymhaiske.

todo · 2021-06-14T02:35:36Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 105 to 115 in 7513bc9

    
                   // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
                   return pw::Status::Unimplemented(); 
        
               } 
        
               pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty & request, chip_rpc_DeviceInfo & response) 
        
               { 
        
                   response.vendor_id = 1234; 
        
                   response.product_id = 5678; 
        
                   response.software_version = 0; 
        
                   return pw::OkStatus(); 
        
               } 
        
           };

This comment was generated by todo based on a `TODO` comment in `7513bc9` in #7584. cc @sweetymhaiske.

todo · 2021-06-14T02:38:14Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 105 to 115 in 5e7970a

    
                   // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
                   return pw::Status::Unimplemented(); 
        
               } 
        
               pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty & request, chip_rpc_DeviceInfo & response) 
        
               { 
        
                   response.vendor_id        = 1234; 
        
                   response.product_id       = 5678; 
        
                   response.software_version = 0; 
        
                   return pw::OkStatus(); 
        
               } 
        
           };

This comment was generated by todo based on a `TODO` comment in `5e7970a` in #7584. cc @sweetymhaiske.

todo · 2021-06-14T03:36:11Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 105 to 115 in 6836c28

    
                   // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
                   return pw::Status::Unimplemented(); 
        
               } 
        
               pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty & request, chip_rpc_DeviceInfo & response) 
        
               { 
        
                   response.vendor_id        = 1234; 
        
                   response.product_id       = 5678; 
        
                   response.software_version = 0; 
        
                   return pw::OkStatus(); 
        
               } 
        
           };

This comment was generated by todo based on a `TODO` comment in `6836c28` in #7584. cc @sweetymhaiske.

todo · 2021-06-14T03:44:45Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 106 to 116 in 78135c5

    
                   // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
                   return pw::Status::Unimplemented(); 
        
               } 
        
               pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty & request, chip_rpc_DeviceInfo & response) 
        
               { 
        
                   response.vendor_id        = 1234; 
        
                   response.product_id       = 5678; 
        
                   response.software_version = 0; 
        
                   return pw::OkStatus(); 
        
               } 
        
           };

This comment was generated by todo based on a `TODO` comment in `78135c5` in #7584. cc @sweetymhaiske.

todo · 2021-06-14T04:16:27Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 106 to 116 in cbddae1

    
                   // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
                   return pw::Status::Unimplemented(); 
        
               } 
        
               pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty & request, chip_rpc_DeviceInfo & response) 
        
               { 
        
                   response.vendor_id        = 1234; 
        
                   response.product_id       = 5678; 
        
                   response.software_version = 0; 
        
                   return pw::OkStatus(); 
        
               } 
        
           };

This comment was generated by todo based on a `TODO` comment in `cbddae1` in #7584. cc @sweetymhaiske.

todo · 2021-06-14T04:51:33Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 106 to 116 in 48da9ad

    
                   // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
                   return pw::Status::Unimplemented(); 
        
               } 
        
               pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty & request, chip_rpc_DeviceInfo & response) 
        
               { 
        
                   response.vendor_id        = 1234; 
        
                   response.product_id       = 5678; 
        
                   response.software_version = 0; 
        
                   return pw::OkStatus(); 
        
               } 
        
           };

This comment was generated by todo based on a `TODO` comment in `48da9ad` in #7584. cc @sweetymhaiske.

dhrishi · 2021-06-14T05:02:41Z

Using a pigweed RPC console, perform actions on device_service, locking_service, and button_service.

@sweetymhaiske Will it be possible to edit the description and actually add the commands/responses you've tested. This will help the users to try it out when the support is merged

examples/lock-app/esp32/CMakeLists.txt

examples/lock-app/esp32/main/CMakeLists.txt

dhrishi · 2021-06-14T05:06:00Z

examples/lock-app/esp32/main/Rpc.cpp

+static bool uartInitialised;
+
+extern "C" void __wrap_esp_log_write(esp_log_level_t level, const char * tag, const char * format, ...)
+{


I see that this is duplicated in multiple examples. Is it possible to move it at a common place?

I moved it to the PigweedLogger service in this CL: https://github.com/project-chip/connectedhomeip/pull/7289/files#diff-35995e2a54a1c71a709bdafbcd4f214d7f23c6e196cb995ed0baa7db05ac3d4dR89

@dhrishi These changes are already the part of above PR(#7289). I will modify it accordingly when it gets merged.

examples/lock-app/esp32/main/main.cpp

dhrishi · 2021-06-14T05:08:42Z

@sweetymhaiske Do you want to update the lock-app README.md with these changes?

sweetymhaiske · 2021-06-14T05:10:20Z

@sweetymhaiske Do you want to update the lock-app README.md with these changes?

@dhrishi I will update README once lock-app console gets added to this example. Once this PR gets merge then Rob will work upon that.

examples/lock-app/esp32/main/locking_service.proto

todo · 2021-06-14T17:22:41Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 106 to 116 in a77ed24

    
                   // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
                   return pw::Status::Unimplemented(); 
        
               } 
        
               pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty & request, chip_rpc_DeviceInfo & response) 
        
               { 
        
                   response.vendor_id        = 1234; 
        
                   response.product_id       = 5678; 
        
                   response.software_version = 0; 
        
                   return pw::OkStatus(); 
        
               } 
        
           };

This comment was generated by todo based on a `TODO` comment in `a77ed24` in #7584. cc @sweetymhaiske.

mspang · 2021-06-14T21:00:26Z

@rgoliver

todo · 2021-06-15T12:30:28Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 106 to 116 in 3aa1fc9

    
                   // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
                   return pw::Status::Unimplemented(); 
        
               } 
        
               pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty & request, chip_rpc_DeviceInfo & response) 
        
               { 
        
                   response.vendor_id        = 1234; 
        
                   response.product_id       = 5678; 
        
                   response.software_version = 0; 
        
                   return pw::OkStatus(); 
        
               } 
        
           };

This comment was generated by todo based on a `TODO` comment in `3aa1fc9` in #7584. cc @sweetymhaiske.

woody-apple · 2021-06-16T04:02:36Z

/rebase

todo · 2021-06-16T04:45:52Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 106 to 116 in 060b6ca

    
                   // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
                   return pw::Status::Unimplemented(); 
        
               } 
        
               pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty & request, chip_rpc_DeviceInfo & response) 
        
               { 
        
                   response.vendor_id        = 1234; 
        
                   response.product_id       = 5678; 
        
                   response.software_version = 0; 
        
                   return pw::OkStatus(); 
        
               } 
        
           };

This comment was generated by todo based on a `TODO` comment in `060b6ca` in #7584. cc @sweetymhaiske.

sweetymhaiske · 2021-06-16T04:46:26Z

/rebase

Done

todo · 2021-06-16T06:06:31Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 106 to 116 in c330375

    
                   // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
                   return pw::Status::Unimplemented(); 
        
               } 
        
               pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty & request, chip_rpc_DeviceInfo & response) 
        
               { 
        
                   response.vendor_id        = 1234; 
        
                   response.product_id       = 5678; 
        
                   response.software_version = 0; 
        
                   return pw::OkStatus(); 
        
               } 
        
           };

This comment was generated by todo based on a `TODO` comment in `c330375` in #7584. cc @sweetymhaiske.

woody-apple · 2021-06-17T01:32:38Z

/rebase

todo · 2021-06-17T01:48:18Z

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

connectedhomeip/examples/lock-app/esp32/main/Rpc.cpp

Lines 106 to 116 in aa1f14e

    
                   // TODO: auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow(); 
        
                   return pw::Status::Unimplemented(); 
        
               } 
        
               pw::Status GetDeviceInfo(ServerContext &, const pw_protobuf_Empty & request, chip_rpc_DeviceInfo & response) 
        
               { 
        
                   response.vendor_id        = 1234; 
        
                   response.product_id       = 5678; 
        
                   response.software_version = 0; 
        
                   return pw::OkStatus(); 
        
               } 
        
           };

This comment was generated by todo based on a `TODO` comment in `aa1f14e` in #7584. cc @sweetymhaiske.

dhrishi · 2021-06-21T04:15:07Z

@sweetymhaiske Is anything pending in this PR?

sweetymhaiske · 2021-06-21T04:53:23Z

@sweetymhaiske Is anything pending in this PR?

Nope.

dhrishi · 2021-06-21T04:54:22Z

@woody-apple @andy31415 Can you guys please help? I think one group is pending to review.

andy31415 · 2021-06-22T13:31:04Z

Pullapprove says @dhrishi rejected. that seems at odds with the comments, so I assume it is actually passing. Will manually merge.

boring-cyborg bot added the examples label Jun 14, 2021

sweetymhaiske force-pushed the lock-app_pigweed branch from 9a69f92 to ca3f3c6 Compare June 14, 2021 02:02

restyled-io bot mentioned this pull request Jun 14, 2021

Restyle ESP32: Add RPC service to lock-app. #7585

Closed

sweetymhaiske force-pushed the lock-app_pigweed branch from ca3f3c6 to 7513bc9 Compare June 14, 2021 02:35

sweetymhaiske force-pushed the lock-app_pigweed branch from 7513bc9 to 5e7970a Compare June 14, 2021 02:38

pullapprove bot requested review from chrisdecenzo, jelderton, jmartinez-silabs, LuDuda, mspang, saurabhst and woody-apple June 14, 2021 02:38

pullapprove bot added the review - pending label Jun 14, 2021

sweetymhaiske force-pushed the lock-app_pigweed branch from 5e7970a to 6836c28 Compare June 14, 2021 03:36

sweetymhaiske force-pushed the lock-app_pigweed branch from 6836c28 to 78135c5 Compare June 14, 2021 03:44

sweetymhaiske force-pushed the lock-app_pigweed branch from 78135c5 to cbddae1 Compare June 14, 2021 04:16

restyled-io bot mentioned this pull request Jun 14, 2021

Restyle ESP32: Add RPC service to lock-app. #7588

Closed

sweetymhaiske force-pushed the lock-app_pigweed branch from cbddae1 to 48da9ad Compare June 14, 2021 04:51

dhrishi requested changes Jun 14, 2021

View reviewed changes

woody-apple approved these changes Jun 14, 2021

View reviewed changes

rgoliver reviewed Jun 14, 2021

View reviewed changes

examples/lock-app/esp32/main/locking_service.proto Outdated Show resolved Hide resolved

sweetymhaiske force-pushed the lock-app_pigweed branch from 48da9ad to a77ed24 Compare June 14, 2021 17:22

sweetymhaiske force-pushed the lock-app_pigweed branch from a77ed24 to 3aa1fc9 Compare June 15, 2021 12:30

rgoliver approved these changes Jun 15, 2021

View reviewed changes

sweetymhaiske force-pushed the lock-app_pigweed branch from 3aa1fc9 to 060b6ca Compare June 16, 2021 04:45

woody-apple force-pushed the lock-app_pigweed branch from 060b6ca to c330375 Compare June 16, 2021 06:06

andy31415 approved these changes Jun 16, 2021

View reviewed changes

jmartinez-silabs approved these changes Jun 16, 2021

View reviewed changes

pullapprove bot added review - changed requested and removed review - pending labels Jun 16, 2021

ESP32: Add RPC service to lock-app.

aa1f14e

woody-apple force-pushed the lock-app_pigweed branch from c330375 to aa1f14e Compare June 17, 2021 01:48

andy31415 requested a review from dhrishi June 22, 2021 13:32

andy31415 merged commit 344fc77 into project-chip:master Jun 22, 2021

nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021

ESP32: Add RPC service to lock-app. (project-chip#7584)

f953ddc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ESP32: Add RPC service to lock-app. #7584

ESP32: Add RPC service to lock-app. #7584

sweetymhaiske commented Jun 14, 2021 •

edited

Loading

todo bot commented Jun 14, 2021

todo bot commented Jun 14, 2021

todo bot commented Jun 14, 2021

todo bot commented Jun 14, 2021

todo bot commented Jun 14, 2021

todo bot commented Jun 14, 2021

todo bot commented Jun 14, 2021

todo bot commented Jun 14, 2021

dhrishi commented Jun 14, 2021

dhrishi Jun 14, 2021

rgoliver Jun 14, 2021

sweetymhaiske Jun 15, 2021

dhrishi commented Jun 14, 2021

sweetymhaiske commented Jun 14, 2021 •

edited

Loading

todo bot commented Jun 14, 2021

mspang commented Jun 14, 2021

todo bot commented Jun 15, 2021

woody-apple commented Jun 16, 2021

todo bot commented Jun 16, 2021

sweetymhaiske commented Jun 16, 2021

todo bot commented Jun 16, 2021

woody-apple commented Jun 17, 2021

todo bot commented Jun 17, 2021

dhrishi commented Jun 21, 2021

sweetymhaiske commented Jun 21, 2021

dhrishi commented Jun 21, 2021

andy31415 commented Jun 22, 2021

ESP32: Add RPC service to lock-app. #7584

ESP32: Add RPC service to lock-app. #7584

Conversation

sweetymhaiske commented Jun 14, 2021 • edited Loading

Problem

Change overview

Testing

todo bot commented Jun 14, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in 9a69f92 in #7584. cc @sweetymhaiske.

todo bot commented Jun 14, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in ca3f3c6 in #7584. cc @sweetymhaiske.

todo bot commented Jun 14, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in 7513bc9 in #7584. cc @sweetymhaiske.

todo bot commented Jun 14, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in 5e7970a in #7584. cc @sweetymhaiske.

todo bot commented Jun 14, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in 6836c28 in #7584. cc @sweetymhaiske.

todo bot commented Jun 14, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in 78135c5 in #7584. cc @sweetymhaiske.

todo bot commented Jun 14, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in cbddae1 in #7584. cc @sweetymhaiske.

todo bot commented Jun 14, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in 48da9ad in #7584. cc @sweetymhaiske.

dhrishi commented Jun 14, 2021

dhrishi Jun 14, 2021

Choose a reason for hiding this comment

rgoliver Jun 14, 2021

Choose a reason for hiding this comment

sweetymhaiske Jun 15, 2021

Choose a reason for hiding this comment

dhrishi commented Jun 14, 2021

sweetymhaiske commented Jun 14, 2021 • edited Loading

todo bot commented Jun 14, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in a77ed24 in #7584. cc @sweetymhaiske.

mspang commented Jun 14, 2021

todo bot commented Jun 15, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in 3aa1fc9 in #7584. cc @sweetymhaiske.

woody-apple commented Jun 16, 2021

todo bot commented Jun 16, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in 060b6ca in #7584. cc @sweetymhaiske.

sweetymhaiske commented Jun 16, 2021

todo bot commented Jun 16, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in c330375 in #7584. cc @sweetymhaiske.

woody-apple commented Jun 17, 2021

todo bot commented Jun 17, 2021

auto err = DeviceLayer::SoftwareUpdateMgr().CheckNow();

This comment was generated by todo based on a TODO comment in aa1f14e in #7584. cc @sweetymhaiske.

dhrishi commented Jun 21, 2021

sweetymhaiske commented Jun 21, 2021

dhrishi commented Jun 21, 2021

andy31415 commented Jun 22, 2021

sweetymhaiske commented Jun 14, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `9a69f92` in #7584. cc @sweetymhaiske.

This comment was generated by todo based on a `TODO` comment in `ca3f3c6` in #7584. cc @sweetymhaiske.

This comment was generated by todo based on a `TODO` comment in `7513bc9` in #7584. cc @sweetymhaiske.

This comment was generated by todo based on a `TODO` comment in `5e7970a` in #7584. cc @sweetymhaiske.

This comment was generated by todo based on a `TODO` comment in `6836c28` in #7584. cc @sweetymhaiske.

This comment was generated by todo based on a `TODO` comment in `78135c5` in #7584. cc @sweetymhaiske.

This comment was generated by todo based on a `TODO` comment in `cbddae1` in #7584. cc @sweetymhaiske.

This comment was generated by todo based on a `TODO` comment in `48da9ad` in #7584. cc @sweetymhaiske.

sweetymhaiske commented Jun 14, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `a77ed24` in #7584. cc @sweetymhaiske.

This comment was generated by todo based on a `TODO` comment in `3aa1fc9` in #7584. cc @sweetymhaiske.

This comment was generated by todo based on a `TODO` comment in `060b6ca` in #7584. cc @sweetymhaiske.

This comment was generated by todo based on a `TODO` comment in `c330375` in #7584. cc @sweetymhaiske.

This comment was generated by todo based on a `TODO` comment in `aa1f14e` in #7584. cc @sweetymhaiske.