Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chip-tool crash in case of commissioning ethernet device. #7753

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Fix chip-tool crash in case of commissioning ethernet device. #7753

merged 1 commit into from
Jun 21, 2021

Conversation

SergeyVasiliev
Copy link
Contributor

Problem

Fix chip-tool crash on commissioning Ethernet device:

./chip-tool pairing ethernet 21589380 3840 192.168.10.131 11097
...
[1623941639.843658][4510] CHIP:CTL: Device confirmed that it has received the root certificate
[1623941639.843700][4510] CHIP:CTL: Operational credentials provisioned on device 0xaaaaf127c778
[1623941639.847772][4510] CHIP:TOO: Secure Pairing Success
[1623941639.849808][4510] CHIP:TOO: Pairing Success
Segmentation fault (core dumped)

Change overview

Need to figure out what SetupNetwork() should do in case of Ethernet device, for now move it to the case where is does nothing.

Testing

Was manually tested on Linux.

@SergeyVasiliev
Fix chip-tool crash in case of commissioning ethernet device. Need to…
5637abd 
… figure out what SetupNetwork() should do in case of Ethernet, for now do nothing
@CLAassistant
Copy link

CLAassistant commented Jun 18, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bzbarsky-apple bzbarsky-apple merged commit ca60cff into project-chip:master Jun 21, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@SergeyVasiliev
Fix chip-tool crash in case of commissioning ethernet device. Need to…
3ac6337 
… figure out what SetupNetwork() should do in case of Ethernet, for now do nothing (project-chip#7753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@hawk248 hawk248 Awaiting requested review from hawk248

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SergeyVasiliev @CLAassistant @tcarmelveilleux @andy31415 @msandstedt @saurabhst @bzbarsky-apple